Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2978273002: Revert of Cros Tablet Window management - Split Screen part II (Closed)

Created:
3 years, 5 months ago by alph
Modified:
3 years, 5 months ago
Reviewers:
varkha, xdai1, oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cros Tablet Window management - Split Screen part II (patchset #9 id:160001 of https://codereview.chromium.org/2955203002/ ) Reason for revert: Broke ash_unittests https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28279 Original issue's description: > Cros Tablet Window management - Split Screen part II > > Wire up the SplitViewController with the overview mode. It's a following > up CL of https://codereview.chromium.org/2960843004/. > > Changes in this CL: > 1. The split view mode can be initiated by dragging the window in > overview mode to the side of the screen > 2. After one window is snapped to one side of the screen, all the other > overview windows will display in the other side of the screen, allowing > the user to select another window to snap. When two windows are snapped > to both sides of the screen, the overview mode will be ended. > 3. The first snapped window will remain snapped until the user > explicitly exit the split view mode. All the other windows (incluing > newly created window) will be open in the other side of the screen. > Clicking/Tapping on the overview button also open the overview windows > in the other side of the screen. > > Not covered in this CL: > 1. The highlighted region showing where split will occur is not > implemented in this CL. > 2. The split divider is not implemented in this CL. > > BUG=725683 > > Review-Url: https://codereview.chromium.org/2955203002 > Cr-Commit-Position: refs/heads/master@{#487542} > Committed: https://chromium.googlesource.com/chromium/src/+/0c6d79c9a3a2bf404ef94220c389924541c92f0b TBR=oshima@chromium.org,varkha@chromium.org,xdai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725683 Review-Url: https://codereview.chromium.org/2978273002 Cr-Commit-Position: refs/heads/master@{#487614} Committed: https://chromium.googlesource.com/chromium/src/+/60bd1f5dcc9cefa2a0f1df2b5ba034567c03d249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -829 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/overview/overview_animation_type.h View 1 chunk +1 line, -4 lines 0 comments Download
D ash/wm/overview/overview_window_drag_controller.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ash/wm/overview/overview_window_drag_controller.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.h View 3 chunks +1 line, -6 lines 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.cc View 4 chunks +3 lines, -42 lines 0 comments Download
M ash/wm/overview/window_grid.h View 5 chunks +1 line, -12 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 5 chunks +6 lines, -26 lines 0 comments Download
M ash/wm/overview/window_selector.h View 7 chunks +4 lines, -35 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 9 chunks +11 lines, -121 lines 0 comments Download
M ash/wm/overview/window_selector_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 3 chunks +3 lines, -36 lines 0 comments Download
M ash/wm/overview/window_selector_item.h View 5 chunks +1 line, -22 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 8 chunks +6 lines, -146 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 3 chunks +0 lines, -69 lines 0 comments Download
M ash/wm/splitview/split_view_controller.h View 4 chunks +4 lines, -5 lines 0 comments Download
M ash/wm/splitview/split_view_controller.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/splitview/split_view_controller_unittest.cc View 5 chunks +2 lines, -62 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Revert of Cros Tablet Window management - Split Screen part II
3 years, 5 months ago (2017-07-18 21:46:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978273002/1
3 years, 5 months ago (2017-07-18 21:46:10 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 21:47:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60bd1f5dcc9cefa2a0f1df2b5ba0...

Powered by Google App Engine
This is Rietveld 408576698