Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 297613002: Sever PendingExtensionManager's dependency on ExtensionService (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Sever PendingExtensionManager's dependency on ExtensionService PendingExtensionManager has no reason to depend on ExtensionService. So remove it. If there is a desire for PendingExtensionManager to be in /extensions, it would be very easy to do so - the only thing keeping it in /chrome is a constant. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -38 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_manager.h View 3 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 7 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Devlin
Fairly small one. :) If there's any desire for PendingExtensionManager to be in /extensions, I ...
6 years, 7 months ago (2014-05-20 17:41:05 UTC) #1
Yoyo Zhou
LGTM We can move it later if necessary.
6 years, 7 months ago (2014-05-20 21:04:52 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-20 21:05:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/297613002/1
6 years, 7 months ago (2014-05-20 21:08:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 00:16:47 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 03:55:56 UTC) #6
Message was sent while issue was closed.
Change committed as 271855

Powered by Google App Engine
This is Rietveld 408576698