Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 297613002: Sever PendingExtensionManager's dependency on ExtensionService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/pending_extension_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <list> 5 #include <list>
6 #include <map> 6 #include <map>
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 } 269 }
270 return 0; 270 return 0;
271 } 271 }
272 272
273 } // namespace 273 } // namespace
274 274
275 // Base class for further specialized test classes. 275 // Base class for further specialized test classes.
276 class MockService : public TestExtensionService { 276 class MockService : public TestExtensionService {
277 public: 277 public:
278 explicit MockService(TestExtensionPrefs* prefs) 278 explicit MockService(TestExtensionPrefs* prefs)
279 : prefs_(prefs), pending_extension_manager_(*this, &profile_) {} 279 : prefs_(prefs), pending_extension_manager_(&profile_) {}
280 280
281 virtual ~MockService() {} 281 virtual ~MockService() {}
282 282
283 virtual PendingExtensionManager* pending_extension_manager() OVERRIDE { 283 virtual PendingExtensionManager* pending_extension_manager() OVERRIDE {
284 ADD_FAILURE() << "Subclass should override this if it will " 284 ADD_FAILURE() << "Subclass should override this if it will "
285 << "be accessed by a test."; 285 << "be accessed by a test.";
286 return &pending_extension_manager_; 286 return &pending_extension_manager_;
287 } 287 }
288 288
289 Profile* profile() { return &profile_; } 289 Profile* profile() { return &profile_; }
(...skipping 1576 matching lines...) Expand 10 before | Expand all | Expand 10 after
1866 // -prodversionmin (shouldn't update if browser version too old) 1866 // -prodversionmin (shouldn't update if browser version too old)
1867 // -manifests & updates arriving out of order / interleaved 1867 // -manifests & updates arriving out of order / interleaved
1868 // -malformed update url (empty, file://, has query, has a # fragment, etc.) 1868 // -malformed update url (empty, file://, has query, has a # fragment, etc.)
1869 // -An extension gets uninstalled while updates are in progress (so it doesn't 1869 // -An extension gets uninstalled while updates are in progress (so it doesn't
1870 // "come back from the dead") 1870 // "come back from the dead")
1871 // -An extension gets manually updated to v3 while we're downloading v2 (ie 1871 // -An extension gets manually updated to v3 while we're downloading v2 (ie
1872 // you don't get downgraded accidentally) 1872 // you don't get downgraded accidentally)
1873 // -An update manifest mentions multiple updates 1873 // -An update manifest mentions multiple updates
1874 1874
1875 } // namespace extensions 1875 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/pending_extension_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698