Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7100)

Unified Diff: chrome/browser/extensions/pending_extension_manager.h

Issue 297613002: Sever PendingExtensionManager's dependency on ExtensionService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/pending_extension_manager.h
diff --git a/chrome/browser/extensions/pending_extension_manager.h b/chrome/browser/extensions/pending_extension_manager.h
index bf2e1fc74c178686687f5d1fef9e0213b1b1db41..50e805b1033e4340c770e53e85da23604f08cc8b 100644
--- a/chrome/browser/extensions/pending_extension_manager.h
+++ b/chrome/browser/extensions/pending_extension_manager.h
@@ -11,7 +11,6 @@
#include "chrome/browser/extensions/pending_extension_info.h"
#include "extensions/common/manifest.h"
-class ExtensionServiceInterface;
class GURL;
namespace base {
@@ -39,16 +38,11 @@ void SetupPendingExtensionManagerForTest(
// time, because they involve downloading, unpacking, and installing.
// This class allows us to avoid race cases where multiple sources install
// the same extension.
-// The extensions service creates an instance of this class, and manages
-// its lifetime. This class should only be used from the UI thread.
+// The ExtensionService creates an instance of this class, and manages its
+// lifetime. This class should only be used from the UI thread.
class PendingExtensionManager {
public:
- // |service| is a reference to the ExtensionService whose pending
- // extensions we are managing. The service creates an instance of
- // this class on construction, and destroys it on destruction.
- // The service remains valid over the entire lifetime of this class.
- explicit PendingExtensionManager(const ExtensionServiceInterface& service,
- content::BrowserContext* context);
+ explicit PendingExtensionManager(content::BrowserContext* context);
~PendingExtensionManager();
// TODO(skerner): Many of these methods can be private once code in
@@ -141,12 +135,6 @@ class PendingExtensionManager {
// method.
void AddForTesting(const PendingExtensionInfo& pending_extension_info);
- // Reference to the extension service whose pending extensions this class is
- // managing. Because this class is a member of |service_|, it is created
- // and destroyed with |service_|. We only use methods from the interface
- // ExtensionServiceInterface.
- const ExtensionServiceInterface& service_;
-
// The BrowserContext with which the manager is associated.
content::BrowserContext* context_;
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/pending_extension_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698