Sever PendingExtensionManager's dependency on ExtensionService

chrome/browser/extensions/pending_extension_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_PENDING_EXTENSION_MANAGER_H_
 #define CHROME_BROWSER_EXTENSIONS_PENDING_EXTENSION_MANAGER_H_
 
 #include <list>
 #include <string>
 
 #include "chrome/browser/extensions/pending_extension_info.h"
 #include "extensions/common/manifest.h"
 
-class ExtensionServiceInterface;
 class GURL;
 
 namespace base {
 class Version;
 }
 
 namespace content {
 class BrowserContext;
 }
 
 FORWARD_DECLARE_TEST(ExtensionServiceTest,
                      UpdatePendingExtensionAlreadyInstalled);
 
 namespace extensions {
 class Extension;
 class PendingExtensionManager;
 
 class ExtensionUpdaterTest;
 void SetupPendingExtensionManagerForTest(
     int count, const GURL& update_url,
     PendingExtensionManager* pending_extension_manager);
 
 // Class PendingExtensionManager manages the set of extensions which are
 // being installed or updated. In general, installation and updates take
 // time, because they involve downloading, unpacking, and installing.
 // This class allows us to avoid race cases where multiple sources install
 // the same extension.
-// The extensions service creates an instance of this class, and manages
-// its lifetime. This class should only be used from the UI thread.
+// The ExtensionService creates an instance of this class, and manages its
+// lifetime. This class should only be used from the UI thread.
 class PendingExtensionManager {
  public:
-  // |service| is a reference to the ExtensionService whose pending
-  // extensions we are managing. The service creates an instance of
-  // this class on construction, and destroys it on destruction.
-  // The service remains valid over the entire lifetime of this class.
-  explicit PendingExtensionManager(const ExtensionServiceInterface& service,
-                                   content::BrowserContext* context);
+  explicit PendingExtensionManager(content::BrowserContext* context);
   ~PendingExtensionManager();
 
   // TODO(skerner): Many of these methods can be private once code in
   // ExtensionService is moved into methods of this class.
 
   // Remove extension with id |id| from the set of pending extensions. Returns
   // true if such an extension was found and removed, false otherwise.
   bool Remove(const std::string& id);
 
   // Get the  information for a pending extension.  Returns a pointer to the
@@ skipping 72 matching lines @@
       Manifest::Location install_source,
       int creation_flags,
       bool mark_acknowledged,
       bool remote_install);
 
   // Add a pending extension record directly.  Used for unit tests that need
   // to set an inital state. Use friendship to allow the tests to call this
   // method.
   void AddForTesting(const PendingExtensionInfo& pending_extension_info);
 
-  // Reference to the extension service whose pending extensions this class is
-  // managing.  Because this class is a member of |service_|, it is created
-  // and destroyed with |service_|. We only use methods from the interface
-  // ExtensionServiceInterface.
-  const ExtensionServiceInterface& service_;
-
   // The BrowserContext with which the manager is associated.
   content::BrowserContext* context_;
 
   PendingExtensionList pending_extension_list_;
 
   FRIEND_TEST_ALL_PREFIXES(::ExtensionServiceTest,
                            UpdatePendingExtensionAlreadyInstalled);
   friend class ExtensionUpdaterTest;
   friend void SetupPendingExtensionManagerForTest(
       int count, const GURL& update_url,
       PendingExtensionManager* pending_extension_manager);
 
   DISALLOW_COPY_AND_ASSIGN(PendingExtensionManager);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_PENDING_EXTENSION_MANAGER_H_