Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2976023002: Revert of customtabs: Remove unnecessary Context plumbing. (Closed)

Created:
3 years, 5 months ago by aberent
Modified:
3 years, 5 months ago
Reviewers:
Yusuf, Yaron, Benoit L
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of customtabs: Remove unnecessary Context plumbing. (patchset #5 id:80001 of https://codereview.chromium.org/2966193002/ ) Reason for revert: Causing compilation errors in ChromeCustomTabsConnection.java. BUG=741667 Original issue's description: > customtabs: Remove unnecessary Context plumbing. > > Also removes Context -> Application downcasts in callers. > > Review-Url: https://codereview.chromium.org/2966193002 > Cr-Commit-Position: refs/heads/master@{#485909} > Committed: https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de933722358985374b TBR=yusufo@chromium.org,yfriedman@chromium.org,lizeb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2976023002 Cr-Commit-Position: refs/heads/master@{#485950} Committed: https://chromium.googlesource.com/chromium/src/+/87795a736613375a0bda2195a27777452b2f99d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -84 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 18 chunks +46 lines, -31 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 12 chunks +23 lines, -20 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 6 chunks +18 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 10 chunks +19 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsTestUtils.java View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aberent
Created Revert of customtabs: Remove unnecessary Context plumbing.
3 years, 5 months ago (2017-07-12 15:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976023002/1
3 years, 5 months ago (2017-07-12 15:05:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/87795a736613375a0bda2195a27777452b2f99d6
3 years, 5 months ago (2017-07-12 15:05:57 UTC) #6
Benoit L
3 years, 5 months ago (2017-07-12 15:26:09 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2979853002/ by lizeb@chromium.org.

The reason for reverting is: Reland: the downstream CL landed in the meantime,
so the revert broke downstream..

Powered by Google App Engine
This is Rietveld 408576698