Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java

Issue 2976023002: Revert of customtabs: Remove unnecessary Context plumbing. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
index dab6580a4daba28f47ffef6a765a3ebe4414375e..2a1179e030aba5b1ff6b90bcf9515177851f5b37 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
@@ -6,6 +6,8 @@
import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_NON_LOW_END_DEVICE;
+import android.app.Application;
+import android.content.Context;
import android.content.Intent;
import android.net.Uri;
import android.os.Build;
@@ -13,6 +15,7 @@
import android.os.Process;
import android.support.customtabs.CustomTabsService;
import android.support.customtabs.CustomTabsSessionToken;
+import android.support.test.InstrumentationRegistry;
import android.support.test.filters.SmallTest;
import org.junit.After;
@@ -46,12 +49,17 @@
private static final String INVALID_SCHEME_URL = "intent://www.google.com";
private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chrome";
+ private Context mAppContext;
+
@Before
public void setUp() throws Exception {
+ mAppContext = InstrumentationRegistry.getInstrumentation()
+ .getTargetContext()
+ .getApplicationContext();
PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX);
LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER).ensureInitialized();
- mCustomTabsConnection = CustomTabsTestUtils.setUpConnection();
- mCustomTabsConnection.resetThrottling(Process.myUid());
+ mCustomTabsConnection = CustomTabsTestUtils.setUpConnection((Application) mAppContext);
+ mCustomTabsConnection.resetThrottling(mAppContext, Process.myUid());
}
@After
@@ -147,7 +155,7 @@
@SmallTest
@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
public void testPrerenderDestroysSpareRenderer() {
- CustomTabsConnection.getInstance().setForcePrerender(true);
+ CustomTabsConnection.getInstance((Application) mAppContext).setForcePrerender(true);
final CustomTabsSessionToken token = assertWarmupAndMayLaunchUrl(null, URL, true);
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
@@ -297,7 +305,7 @@
@SmallTest
@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
public void testStillHighConfidenceMayLaunchUrlWithSeveralUrls() {
- CustomTabsConnection.getInstance().setForcePrerender(true);
+ CustomTabsConnection.getInstance((Application) mAppContext).setForcePrerender(true);
final CustomTabsSessionToken token =
CustomTabsSessionToken.createDummySessionTokenForTesting();
Assert.assertTrue(mCustomTabsConnection.newSession(token));
@@ -344,7 +352,7 @@
@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
@RetryOnFailure
public void testCanCancelPrerender() {
- CustomTabsConnection.getInstance().setForcePrerender(true);
+ CustomTabsConnection.getInstance((Application) mAppContext).setForcePrerender(true);
final CustomTabsSessionToken token = assertWarmupAndMayLaunchUrl(null, URL, true);
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
@@ -431,9 +439,9 @@
@SmallTest
public void testMultipleMayLaunchUrl() {
CustomTabsSessionToken token = assertWarmupAndMayLaunchUrl(null, URL, true);
- mCustomTabsConnection.resetThrottling(Process.myUid());
+ mCustomTabsConnection.resetThrottling(mAppContext, Process.myUid());
assertWarmupAndMayLaunchUrl(token, URL, true);
- mCustomTabsConnection.resetThrottling(Process.myUid());
+ mCustomTabsConnection.resetThrottling(mAppContext, Process.myUid());
assertWarmupAndMayLaunchUrl(token, URL2, true);
}
@@ -537,9 +545,9 @@
@SmallTest
public void testThrottlingAcrossSessions() {
CustomTabsSessionToken token = assertWarmupAndMayLaunchUrl(null, URL, true);
- mCustomTabsConnection.resetThrottling(Process.myUid());
+ mCustomTabsConnection.resetThrottling(mAppContext, Process.myUid());
CustomTabsSessionToken token2 = assertWarmupAndMayLaunchUrl(null, URL, true);
- mCustomTabsConnection.resetThrottling(Process.myUid());
+ mCustomTabsConnection.resetThrottling(mAppContext, Process.myUid());
for (int i = 0; i < 10; i++) {
mCustomTabsConnection.mayLaunchUrl(token, Uri.parse(URL), null, null);
}
@@ -550,7 +558,7 @@
@SmallTest
@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
public void testBanningWorks() {
- mCustomTabsConnection.ban(Process.myUid());
+ mCustomTabsConnection.ban(mAppContext, Process.myUid());
final CustomTabsSessionToken token =
CustomTabsSessionToken.createDummySessionTokenForTesting();
Assert.assertTrue(mCustomTabsConnection.newSession(token));
@@ -570,7 +578,7 @@
@SmallTest
@Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE)
public void testBanningDisabledForCellular() {
- mCustomTabsConnection.ban(Process.myUid());
+ mCustomTabsConnection.ban(mAppContext, Process.myUid());
final CustomTabsSessionToken token =
CustomTabsSessionToken.createDummySessionTokenForTesting();
Assert.assertTrue(mCustomTabsConnection.newSession(token));

Powered by Google App Engine
This is Rietveld 408576698