customtabs: Remove unnecessary Context plumbing.

customtabs: Remove unnecessary Context plumbing.

Also removes Context -> Application downcasts in callers.

Review-Url: https://codereview.chromium.org/2966193002
Cr-Commit-Position: refs/heads/master@{#485909}
Committed: https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de933722358985374b

[Benoit L, 2017-07-05 14:20:33]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2017-07-05 19:24:39]

lgtm

[Benoit L, 2017-07-06 11:22:52]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 11:23:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 12:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 12:31:19]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Benoit L, 2017-07-07 14:29:18]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 14:29:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benoit L, 2017-07-07 14:36:44]

lizeb@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Benoit L, 2017-07-07 14:36:44]

+yfriedman:
For
chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java

PTAL, thanks!

[commit-bot: I haz the power, 2017-07-07 15:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 15:43:31]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Benoit L, 2017-07-07 15:59:35]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 15:59:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yaron, 2017-07-07 16:00:28]

https://codereview.chromium.org/2966193002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2966193002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:138:
private final CustomTabsConnection mConnection =
CustomTabsConnection.getInstance();
this could happen at a very different time from when it was before. I'm not
super familiar with this so wondering whether that's ok?
It's also a little weird to have a member variable for a singleton, no?

[Benoit L, 2017-07-07 16:16:08]

Thanks!

https://codereview.chromium.org/2966193002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2966193002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:138:
private final CustomTabsConnection mConnection =
CustomTabsConnection.getInstance();
On 2017/07/07 16:00:27, Yaron wrote:
> this could happen at a very different time from when it was before. I'm not
> super familiar with this so wondering whether that's ok?
> It's also a little weird to have a member variable for a singleton, no?

It is OK, as CustomTabsConnection only depends on the Application object being
there, which is necessarily the case before the Activity is created.

The member variable is merely there because we always use CustomTabsConnection
from CustomTabActivity, as a way to avoid repeating
CustomTabsConnection.getInstance() in a lot of places below. It also avoid a
bunch of atomic variable lookups and method calls, although that's almost
certainly insignificant.

CustomTabActivity is always a user of CustomTabsConnection, and we never destroy
the CustomTabsConnection instance anyway.

[commit-bot: I haz the power, 2017-07-07 16:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 16:46:18]

Dry run: This issue passed the CQ dry run.

[Yaron, 2017-07-07 21:05:39]

lgtm

https://codereview.chromium.org/2966193002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2966193002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:207:
@SuppressFBWarnings("BC_UNCONFIRMED_CAST")
nit: remove

[Benoit L, 2017-07-12 09:01:20]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2017-07-12 09:01:20]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2966193002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-07-12 09:01:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 09:54:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499850080485930,
"parent_rev": "9374bb50071ca91dfb336cbaa67328d2facd950c", "commit_rev":
"3c9d5e08c8a6d8ad34a8f3dab61a10544fe6fe79"}

[commit-bot: I haz the power, 2017-07-12 09:55:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499850080485930,
"parent_rev": "ad6d8a9bbf9bd5e2ec69fa3126c4baeec753fcf8", "commit_rev":
"a0d1c1531de988606c0425de933722358985374b"}

[commit-bot: I haz the power, 2017-07-12 09:55:23]

Description was changed from

==========
customtabs: Remove unnecessary Context plumbing.

Also removes Context -> Application downcasts in callers.
==========

to

==========
customtabs: Remove unnecessary Context plumbing.

Also removes Context -> Application downcasts in callers.

Review-Url: https://codereview.chromium.org/2966193002
Cr-Commit-Position: refs/heads/master@{#485909}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de9337...
==========

[commit-bot: I haz the power, 2017-07-12 09:55:25]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de9337...

[aberent, 2017-07-12 15:05:04]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2976023002/ by aberent@chromium.org.

The reason for reverting is: Causing compilation errors in
ChromeCustomTabsConnection.java.

BUG=741667.