Decrease call sites of ScriptState::current()

Decrease call sites of ScriptState::current()

Basically ScriptState::current() should be called only in the binding layer where the current ScriptState is guaranteed to be correct. This CL removes call sites of ScriptState::current() in non-binding layer.

BUG=357144
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174599

[haraken, 2014-05-22 12:15:48]

PTAL

[dcarney, 2014-05-22 12:17:42]

lgtm

[haraken, 2014-05-22 12:19:53]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:20:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/297513008/1

[commit-bot: I haz the power, 2014-05-22 12:20:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:20:46]

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObject.cpp
  Hunk #6 FAILED at 5234.
  Hunk #7 FAILED at 5946.
  Hunk #8 succeeded at 7587 (offset 396 lines).
  Hunk #9 succeeded at 7601 (offset 396 lines).
  Hunk #10 succeeded at 7616 (offset 396 lines).
  Hunk #11 succeeded at 7631 (offset 396 lines).
  Hunk #12 FAILED at 7251.
  3 out of 12 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObject.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObject.cpp
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp
b/Source/bindings/tests/results/V8TestObject.cpp
index
5a7aa9118379d65756793d9c8a59f19e1f66f1aa..5d5d6f0bd8031bce20f35b6d12fd77b5890dc657
100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -858,7 +858,7 @@ static void
nodeFilterAttributeAttributeSetter(v8::Local<v8::Value> v8Value, con
 {
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
-    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, cppValue,
toNodeFilter(v8Value, info.Holder(), info.GetIsolate()));
+    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, cppValue,
toNodeFilter(v8Value, info.Holder(), ScriptState::current(info.GetIsolate())));
     impl->setNodeFilterAttribute(WTF::getPtr(cppValue));
 }
 
@@ -1861,8 +1861,8 @@ static void
callWithScriptStateAnyAttributeAttributeGetter(const v8::PropertyCal
 {
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    v8SetReturnValue(info,
impl->callWithScriptStateAnyAttribute(state).v8Value());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    v8SetReturnValue(info,
impl->callWithScriptStateAnyAttribute(scriptState).v8Value());
 }
 
 static void
callWithScriptStateAnyAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -1877,7 +1877,7 @@ static void
callWithScriptStateAnyAttributeAttributeSetter(v8::Local<v8::Value>
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
     TONATIVE_VOID(ScriptValue, cppValue,
ScriptValue(ScriptState::current(info.GetIsolate()), v8Value));
-    impl->setCallWithScriptStateAnyAttribute(state, cppValue);
+    impl->setCallWithScriptStateAnyAttribute(scriptState, cppValue);
 }
 
 static void
callWithScriptStateAnyAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)
@@ -1892,8 +1892,8 @@ static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeGetter(co
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    v8SetReturnValue(info,
impl->callWithExecutionContextAndScriptStateAnyAttribute(state,
scriptContext).v8Value());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    v8SetReturnValue(info,
impl->callWithExecutionContextAndScriptStateAnyAttribute(scriptState,
scriptContext).v8Value());
 }
 
 static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -1909,7 +1909,7 @@ static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeSetter(v8
     TestObject* impl = V8TestObject::toNative(holder);
     TONATIVE_VOID(ScriptValue, cppValue,
ScriptValue(ScriptState::current(info.GetIsolate()), v8Value));
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
-    impl->setCallWithExecutionContextAndScriptStateAnyAttribute(state,
scriptContext, cppValue);
+    impl->setCallWithExecutionContextAndScriptStateAnyAttribute(scriptState,
scriptContext, cppValue);
 }
 
 static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)
@@ -5234,7 +5234,7 @@ static void
voidMethodMediaQueryListListenerArgMethod(const v8::FunctionCallback
         return;
     }
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    TONATIVE_VOID(RefPtrWillBeRawPtr<MediaQueryListListener>,
mediaQueryListListenerArg,
MediaQueryListListener::create(ScriptValue(ScriptState::current(info.GetIsolate()),
info[0])));
+    TONATIVE_VOID(RefPtrWillBeRawPtr<MediaQueryListListener>,
mediaQueryListListenerArg,
MediaQueryListListener::create(ScriptState::current(info.GetIsolate()),
ScriptValue(ScriptState::current(info.GetIsolate()), info[0])));
     impl->voidMethodMediaQueryListListenerArg(mediaQueryListListenerArg);
 }
 
@@ -5946,7 +5946,7 @@ static void voidMethodNodeFilterArgMethod(const
v8::FunctionCallbackInfo<v8::Val
         return;
     }
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, nodeFilterArg,
toNodeFilter(info[0], info.Holder(), info.GetIsolate()));
+    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, nodeFilterArg,
toNodeFilter(info[0], info.Holder(), ScriptState::current(info.GetIsolate())));
     impl->voidMethodNodeFilterArg(nodeFilterArg.release());
 }
 
@@ -7191,8 +7191,8 @@ static void
callWithExecutionContextVoidMethodMethodCallback(const v8::FunctionC
 static void callWithScriptStateVoidMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    impl->callWithScriptStateVoidMethod(state);
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    impl->callWithScriptStateVoidMethod(scriptState);
 }
 
 static void callWithScriptStateVoidMethodMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
@@ -7205,8 +7205,8 @@ static void
callWithScriptStateVoidMethodMethodCallback(const v8::FunctionCallba
 static void callWithScriptStateLongMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    int result = impl->callWithScriptStateLongMethod(state);
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    int result = impl->callWithScriptStateLongMethod(scriptState);
     v8SetReturnValueInt(info, result);
 }
 
@@ -7220,9 +7220,9 @@ static void
callWithScriptStateLongMethodMethodCallback(const v8::FunctionCallba
 static void callWithScriptStateExecutionContextVoidMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
-    impl->callWithScriptStateExecutionContextVoidMethod(state, scriptContext);
+    impl->callWithScriptStateExecutionContextVoidMethod(scriptState,
scriptContext);
 }
 
 static void callWithScriptStateExecutionContextVoidMethodMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
@@ -7235,9 +7235,9 @@ static void
callWithScriptStateExecutionContextVoidMethodMethodCallback(const v8
 static void callWithScriptStateScriptArgumentsVoidMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info, 0));
-    impl->callWithScriptStateScriptArgumentsVoidMethod(state,
scriptArguments.release());
+    impl->callWithScriptStateScriptArgumentsVoidMethod(scriptState,
scriptArguments.release());
 }
 
 static void callWithScriptStateScriptArgumentsVoidMethodMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
@@ -7251,15 +7251,15 @@ static void
callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArgMethod
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
     if (UNLIKELY(info.Length() <= 0)) {
-        ScriptState* state = ScriptState::current(info.GetIsolate());
+        ScriptState* scriptState = ScriptState::current(info.GetIsolate());
         RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info,
1));
-       
impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(state,
scriptArguments.release());
+       
impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(scriptState,
scriptArguments.release());
         return;
     }
     TONATIVE_VOID(bool, optionalBooleanArg, info[0]->BooleanValue());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info, 1));
-    impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(state,
scriptArguments.release(), optionalBooleanArg);
+   
impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(scriptState,
scriptArguments.release(), optionalBooleanArg);
 }
 
 static void
callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArgMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)

[haraken, 2014-05-22 12:22:07]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:22:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/297513008/20001

[commit-bot: I haz the power, 2014-05-22 12:23:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:23:07]

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObject.cpp
  Hunk #6 FAILED at 5234.
  Hunk #7 FAILED at 5946.
  Hunk #8 succeeded at 7587 (offset 396 lines).
  Hunk #9 succeeded at 7601 (offset 396 lines).
  Hunk #10 succeeded at 7616 (offset 396 lines).
  Hunk #11 succeeded at 7631 (offset 396 lines).
  Hunk #12 FAILED at 7251.
  3 out of 12 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObject.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObject.cpp
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp
b/Source/bindings/tests/results/V8TestObject.cpp
index
5a7aa9118379d65756793d9c8a59f19e1f66f1aa..5d5d6f0bd8031bce20f35b6d12fd77b5890dc657
100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -858,7 +858,7 @@ static void
nodeFilterAttributeAttributeSetter(v8::Local<v8::Value> v8Value, con
 {
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
-    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, cppValue,
toNodeFilter(v8Value, info.Holder(), info.GetIsolate()));
+    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, cppValue,
toNodeFilter(v8Value, info.Holder(), ScriptState::current(info.GetIsolate())));
     impl->setNodeFilterAttribute(WTF::getPtr(cppValue));
 }
 
@@ -1861,8 +1861,8 @@ static void
callWithScriptStateAnyAttributeAttributeGetter(const v8::PropertyCal
 {
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    v8SetReturnValue(info,
impl->callWithScriptStateAnyAttribute(state).v8Value());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    v8SetReturnValue(info,
impl->callWithScriptStateAnyAttribute(scriptState).v8Value());
 }
 
 static void
callWithScriptStateAnyAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -1877,7 +1877,7 @@ static void
callWithScriptStateAnyAttributeAttributeSetter(v8::Local<v8::Value>
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
     TONATIVE_VOID(ScriptValue, cppValue,
ScriptValue(ScriptState::current(info.GetIsolate()), v8Value));
-    impl->setCallWithScriptStateAnyAttribute(state, cppValue);
+    impl->setCallWithScriptStateAnyAttribute(scriptState, cppValue);
 }
 
 static void
callWithScriptStateAnyAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)
@@ -1892,8 +1892,8 @@ static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeGetter(co
     v8::Handle<v8::Object> holder = info.Holder();
     TestObject* impl = V8TestObject::toNative(holder);
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    v8SetReturnValue(info,
impl->callWithExecutionContextAndScriptStateAnyAttribute(state,
scriptContext).v8Value());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    v8SetReturnValue(info,
impl->callWithExecutionContextAndScriptStateAnyAttribute(scriptState,
scriptContext).v8Value());
 }
 
 static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeGetterCallback(v8::Local<v8::String>,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -1909,7 +1909,7 @@ static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeSetter(v8
     TestObject* impl = V8TestObject::toNative(holder);
     TONATIVE_VOID(ScriptValue, cppValue,
ScriptValue(ScriptState::current(info.GetIsolate()), v8Value));
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
-    impl->setCallWithExecutionContextAndScriptStateAnyAttribute(state,
scriptContext, cppValue);
+    impl->setCallWithExecutionContextAndScriptStateAnyAttribute(scriptState,
scriptContext, cppValue);
 }
 
 static void
callWithExecutionContextAndScriptStateAnyAttributeAttributeSetterCallback(v8::Local<v8::String>,
v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)
@@ -5234,7 +5234,7 @@ static void
voidMethodMediaQueryListListenerArgMethod(const v8::FunctionCallback
         return;
     }
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    TONATIVE_VOID(RefPtrWillBeRawPtr<MediaQueryListListener>,
mediaQueryListListenerArg,
MediaQueryListListener::create(ScriptValue(ScriptState::current(info.GetIsolate()),
info[0])));
+    TONATIVE_VOID(RefPtrWillBeRawPtr<MediaQueryListListener>,
mediaQueryListListenerArg,
MediaQueryListListener::create(ScriptState::current(info.GetIsolate()),
ScriptValue(ScriptState::current(info.GetIsolate()), info[0])));
     impl->voidMethodMediaQueryListListenerArg(mediaQueryListListenerArg);
 }
 
@@ -5946,7 +5946,7 @@ static void voidMethodNodeFilterArgMethod(const
v8::FunctionCallbackInfo<v8::Val
         return;
     }
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, nodeFilterArg,
toNodeFilter(info[0], info.Holder(), info.GetIsolate()));
+    TONATIVE_VOID(RefPtrWillBeRawPtr<NodeFilter>, nodeFilterArg,
toNodeFilter(info[0], info.Holder(), ScriptState::current(info.GetIsolate())));
     impl->voidMethodNodeFilterArg(nodeFilterArg.release());
 }
 
@@ -7191,8 +7191,8 @@ static void
callWithExecutionContextVoidMethodMethodCallback(const v8::FunctionC
 static void callWithScriptStateVoidMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    impl->callWithScriptStateVoidMethod(state);
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    impl->callWithScriptStateVoidMethod(scriptState);
 }
 
 static void callWithScriptStateVoidMethodMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
@@ -7205,8 +7205,8 @@ static void
callWithScriptStateVoidMethodMethodCallback(const v8::FunctionCallba
 static void callWithScriptStateLongMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
-    int result = impl->callWithScriptStateLongMethod(state);
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    int result = impl->callWithScriptStateLongMethod(scriptState);
     v8SetReturnValueInt(info, result);
 }
 
@@ -7220,9 +7220,9 @@ static void
callWithScriptStateLongMethodMethodCallback(const v8::FunctionCallba
 static void callWithScriptStateExecutionContextVoidMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
-    impl->callWithScriptStateExecutionContextVoidMethod(state, scriptContext);
+    impl->callWithScriptStateExecutionContextVoidMethod(scriptState,
scriptContext);
 }
 
 static void callWithScriptStateExecutionContextVoidMethodMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
@@ -7235,9 +7235,9 @@ static void
callWithScriptStateExecutionContextVoidMethodMethodCallback(const v8
 static void callWithScriptStateScriptArgumentsVoidMethodMethod(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info, 0));
-    impl->callWithScriptStateScriptArgumentsVoidMethod(state,
scriptArguments.release());
+    impl->callWithScriptStateScriptArgumentsVoidMethod(scriptState,
scriptArguments.release());
 }
 
 static void callWithScriptStateScriptArgumentsVoidMethodMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)
@@ -7251,15 +7251,15 @@ static void
callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArgMethod
 {
     TestObject* impl = V8TestObject::toNative(info.Holder());
     if (UNLIKELY(info.Length() <= 0)) {
-        ScriptState* state = ScriptState::current(info.GetIsolate());
+        ScriptState* scriptState = ScriptState::current(info.GetIsolate());
         RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info,
1));
-       
impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(state,
scriptArguments.release());
+       
impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(scriptState,
scriptArguments.release());
         return;
     }
     TONATIVE_VOID(bool, optionalBooleanArg, info[0]->BooleanValue());
-    ScriptState* state = ScriptState::current(info.GetIsolate());
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
     RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info, 1));
-    impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(state,
scriptArguments.release(), optionalBooleanArg);
+   
impl->callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArg(scriptState,
scriptArguments.release(), optionalBooleanArg);
 }
 
 static void
callWithScriptStateScriptArgumentsVoidMethodOptionalBooleanArgMethodCallback(const
v8::FunctionCallbackInfo<v8::Value>& info)

[haraken, 2014-05-22 12:25:33]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:26:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/297513008/40001

[commit-bot: I haz the power, 2014-05-22 21:52:33]

Change committed as 174599