Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: Source/core/css/FontFaceSet.cpp

Issue 297513008: Decrease call sites of ScriptState::current() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/FontFace.idl ('k') | Source/core/css/MediaQueryListListener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/FontFaceSet.cpp
diff --git a/Source/core/css/FontFaceSet.cpp b/Source/core/css/FontFaceSet.cpp
index 8621037478094c8a7dbb8cec7cca5d5546a044b2..4283b911a8641ff85482e1304717708a132424b3 100644
--- a/Source/core/css/FontFaceSet.cpp
+++ b/Source/core/css/FontFaceSet.cpp
@@ -50,9 +50,9 @@ static const char defaultFontFamily[] = "sans-serif";
class LoadFontPromiseResolver FINAL : public FontFace::LoadFontCallback {
public:
- static PassRefPtrWillBeRawPtr<LoadFontPromiseResolver> create(FontFaceArray faces, ExecutionContext* context)
+ static PassRefPtrWillBeRawPtr<LoadFontPromiseResolver> create(FontFaceArray faces, ScriptState* scriptState)
{
- return adoptRefWillBeNoop(new LoadFontPromiseResolver(faces, context));
+ return adoptRefWillBeNoop(new LoadFontPromiseResolver(faces, scriptState));
}
void loadFonts(ExecutionContext*);
@@ -64,10 +64,10 @@ public:
virtual void trace(Visitor*) OVERRIDE;
private:
- LoadFontPromiseResolver(FontFaceArray faces, ExecutionContext* context)
+ LoadFontPromiseResolver(FontFaceArray faces, ScriptState* scriptState)
: m_numLoading(faces.size())
, m_errorOccured(false)
- , m_resolver(ScriptPromiseResolverWithContext::create(ScriptState::current(toIsolate(context))))
+ , m_resolver(ScriptPromiseResolverWithContext::create(scriptState))
{
m_fontFaces.swap(faces);
}
@@ -457,7 +457,7 @@ ScriptPromise FontFaceSet::load(ScriptState* scriptState, const String& fontStri
segmentedFontFace->match(nullToSpace(text), faces);
}
- RefPtrWillBeRawPtr<LoadFontPromiseResolver> resolver = LoadFontPromiseResolver::create(faces, executionContext());
+ RefPtrWillBeRawPtr<LoadFontPromiseResolver> resolver = LoadFontPromiseResolver::create(faces, scriptState);
ScriptPromise promise = resolver->promise();
resolver->loadFonts(executionContext()); // After this, resolver->promise() may return null.
return promise;
« no previous file with comments | « Source/core/css/FontFace.idl ('k') | Source/core/css/MediaQueryListListener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698