Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: Source/bindings/v8/custom/V8MutationObserverCustom.cpp

Issue 297513008: Decrease call sites of ScriptState::current() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 return; 50 return;
51 } 51 }
52 52
53 v8::Local<v8::Value> arg = info[0]; 53 v8::Local<v8::Value> arg = info[0];
54 if (!arg->IsFunction()) { 54 if (!arg->IsFunction()) {
55 exceptionState.throwTypeError("Callback argument must be a function"); 55 exceptionState.throwTypeError("Callback argument must be a function");
56 exceptionState.throwIfNeeded(); 56 exceptionState.throwIfNeeded();
57 return; 57 return;
58 } 58 }
59 59
60 ExecutionContext* context = currentExecutionContext(info.GetIsolate());
61 v8::Handle<v8::Object> wrapper = info.Holder(); 60 v8::Handle<v8::Object> wrapper = info.Holder();
62 61
63 OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8 ::Function>::Cast(arg), context, wrapper, info.GetIsolate()); 62 OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8 ::Function>::Cast(arg), wrapper, ScriptState::current(info.GetIsolate()));
64 RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(cal lback.release()); 63 RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(cal lback.release());
65 64
66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Depende nt); 65 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Depende nt);
67 info.GetReturnValue().Set(wrapper); 66 info.GetReturnValue().Set(wrapper);
68 } 67 }
69 68
70 void V8MutationObserver::visitDOMWrapper(void* object, const v8::Persistent<v8:: Object>& wrapper, v8::Isolate* isolate) 69 void V8MutationObserver::visitDOMWrapper(void* object, const v8::Persistent<v8:: Object>& wrapper, v8::Isolate* isolate)
71 { 70 {
72 MutationObserver* observer = static_cast<MutationObserver*>(object); 71 MutationObserver* observer = static_cast<MutationObserver*>(object);
73 HashSet<Node*> observedNodes = observer->getObservedNodes(); 72 HashSet<Node*> observedNodes = observer->getObservedNodes();
74 for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNode s.end(); ++it) { 73 for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNode s.end(); ++it) {
75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(*it, isolate))); 74 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(*it, isolate)));
76 isolate->SetReferenceFromGroup(id, wrapper); 75 isolate->SetReferenceFromGroup(id, wrapper);
77 } 76 }
78 } 77 }
79 78
80 } // namespace WebCore 79 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698