Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2973763002: Revert of Make OS audio buffer size limits visible. (Closed)

Created:
3 years, 5 months ago by Ken Russell (Google)
Modified:
3 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mac-reviews_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make OS audio buffer size limits visible. (patchset #13 id:240001 of https://codereview.chromium.org/2908073002/ ) Reason for revert: New test is asserting on Linux GPU bots (physical machines); see http://crbug.com/708917 . Original issue's description: > Make OS audio buffer size limits visible. > > Make platform-specific audio buffer size limits visible in limits.h and update AudioLatency::GetExactBufferSize() to allow requesting buffer sizes down to the minimum. Update OSX and CRAS to allow audio buffer sizes below their previous minimums when using GetExactBufferSize(), for use in Web Audio AudioContext creation with a latencyHint. > > BUG=708917 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2908073002 > Cr-Commit-Position: refs/heads/master@{#484231} > Committed: https://chromium.googlesource.com/chromium/src/+/3fe2409358437193a07496c2d0a0b559ef399760 TBR=mkwst@chromium.org,dalecurtis@chromium.org,hongchan@chromium.org,olka@chromium.org,peter@chromium.org,rtoy@chromium.org,andrew.macpherson@soundtrap.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -228 lines) Patch
M content/renderer/media/renderer_webaudiodevice_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M media/audio/audio_manager_unittest.cc View 2 chunks +0 lines, -104 lines 0 comments Download
M media/audio/cras/audio_manager_cras.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 4 chunks +21 lines, -16 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M media/base/audio_latency.cc View 2 chunks +3 lines, -24 lines 0 comments Download
M media/base/limits.h View 2 chunks +0 lines, -16 lines 0 comments Download
D media/base/mac/audio_latency_mac.h View 1 chunk +0 lines, -18 lines 0 comments Download
D media/base/mac/audio_latency_mac.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ken Russell (Google)
Created Revert of Make OS audio buffer size limits visible.
3 years, 5 months ago (2017-07-06 04:44:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973763002/1
3 years, 5 months ago (2017-07-06 04:44:41 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-06 04:44:44 UTC) #5
Ken Russell (switch to Gerrit)
I think this failed to start the CQ because the Gerrit migration has happened. Reverting ...
3 years, 5 months ago (2017-07-06 04:47:38 UTC) #7
Ken Russell (switch to Gerrit)
3 years, 5 months ago (2017-07-06 04:49:11 UTC) #9
Message was sent while issue was closed.
On 2017/07/06 04:47:38, Ken Russell (switch to Gerrit) wrote:
> I think this failed to start the CQ because the Gerrit migration has happened.
> Reverting this by hand.

Nope, reverted with the wrong account.

Powered by Google App Engine
This is Rietveld 408576698