Specify leading in sp units to it scales with the text.

Specify leading in sp units to it scales with the text.

BUG=737952
Review-Url: https://codereview.chromium.org/2973513002
Cr-Commit-Position: refs/heads/master@{#484123}
Committed: https://chromium.googlesource.com/chromium/src/+/b1bf76a8220d7f1815cf07aff2d1fca5bfc4e982

[Michael van Ouwerkerk, 2017-07-04 13:06:30]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 13:06:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael van Ouwerkerk, 2017-07-04 13:07:03]

mvanouwerkerk@chromium.org changed reviewers:
+ bauerb@chromium.org

[Michael van Ouwerkerk, 2017-07-04 13:07:04]

Bernhard, could you take a look please?

[commit-bot: I haz the power, 2017-07-04 13:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 13:57:45]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-07-04 14:23:37]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org, peconn@chromium.org

[Bernhard Bauer, 2017-07-04 14:23:38]

I vaguely remember something about intentionally keeping the baseline grid even
with larger font sizes, but I can't find any reference to it now. Peter,
Nicolas, does anyone of you remember?

[dgn, 2017-07-04 14:31:15]

On 2017/07/04 14:23:38, Bernhard Bauer wrote:
> I vaguely remember something about intentionally keeping the baseline grid
even
> with larger font sizes, but I can't find any reference to it now. Peter,
> Nicolas, does anyone of you remember?

No, doesn't ring a bell :/

[PEConn, 2017-07-04 14:33:16]

On 2017/07/04 14:31:15, dgn wrote:
> On 2017/07/04 14:23:38, Bernhard Bauer wrote:
> > I vaguely remember something about intentionally keeping the baseline grid
> even
> > with larger font sizes, but I can't find any reference to it now. Peter,
> > Nicolas, does anyone of you remember?
> 
> No, doesn't ring a bell :/

Not with me either.

[Michael van Ouwerkerk, 2017-07-04 14:48:37]

On 2017/07/04 14:33:16, PEConn wrote:
> On 2017/07/04 14:31:15, dgn wrote:
> > On 2017/07/04 14:23:38, Bernhard Bauer wrote:
> > > I vaguely remember something about intentionally keeping the baseline grid
> > even
> > > with larger font sizes, but I can't find any reference to it now. Peter,
> > > Nicolas, does anyone of you remember?
> > 
> > No, doesn't ring a bell :/
> 
> Not with me either.

Looks like we used dp units from the CL in which TextViewWithLeading was created
in May 2016:
https://codereview.chromium.org/1955813002/diff/20001/chrome/android/java/res...

[Bernhard Bauer, 2017-07-04 15:19:36]

I appear to have weird dreams... LGTM.

[Michael van Ouwerkerk, 2017-07-04 16:02:51]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2017-07-04 16:02:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 16:06:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499184171602050, "parent_rev":
"ff48fa86d77941267bb8ab338f45282a1fabdd64", "commit_rev":
"b1bf76a8220d7f1815cf07aff2d1fca5bfc4e982"}

[commit-bot: I haz the power, 2017-07-04 16:07:05]

Description was changed from

==========
Specify leading in sp units to it scales with the text.

BUG=737952
==========

to

==========
Specify leading in sp units to it scales with the text.

BUG=737952

Review-Url: https://codereview.chromium.org/2973513002
Cr-Commit-Position: refs/heads/master@{#484123}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1bf76a8220d7f1815cf07aff2d1...
==========

[commit-bot: I haz the power, 2017-07-04 16:07:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1bf76a8220d7f1815cf07aff2d1...