chrome/android/java/res/layout/new_tab_page_snippets_card.xml - Issue 2973513002: Specify leading in sp units to it scales with the text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2973513002: Specify leading in sp units to it scales with the text. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

index d59c45866009cc370d583c71a90727c812c86dca..b638198216f6a1f08c380937292698ad4cb63502 100644

--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

@@ -23,7 +23,7 @@

android:ellipsize="end"

android:textSize="16sp"

android:textColor="@color/snippets_headline_text_color"

- chrome:leading="24dp" />

+ chrome:leading="24sp" />

<org.chromium.ui.widget.TextViewWithLeading

android:id="@+id/article_snippet"

@@ -37,7 +37,7 @@

android:ellipsize="end"

android:textSize="14sp"

android:textColor="@color/snippets_text_color"

- chrome:leading="20dp" />

+ chrome:leading="20sp" />

<LinearLayout

tools:ignore="UseCompoundDrawables"

« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_card_large_thumbnail.xml » ('j') | no next file with comments »