Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2973513002: Specify leading in sp units to it scales with the text. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_card_large_thumbnail.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <RelativeLayout 6 <RelativeLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto" 8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
9 xmlns:tools="http://schemas.android.com/tools" 9 xmlns:tools="http://schemas.android.com/tools"
10 android:id="@+id/snippets_card_view" 10 android:id="@+id/snippets_card_view"
11 android:layout_width="match_parent" 11 android:layout_width="match_parent"
12 android:layout_height="wrap_content" 12 android:layout_height="wrap_content"
13 android:foreground="@drawable/button_borderless_compat" 13 android:foreground="@drawable/button_borderless_compat"
14 android:padding="@dimen/snippets_padding" 14 android:padding="@dimen/snippets_padding"
15 android:background="@drawable/card_single"> 15 android:background="@drawable/card_single">
16 16
17 <org.chromium.ui.widget.TextViewWithLeading 17 <org.chromium.ui.widget.TextViewWithLeading
18 android:id="@+id/article_headline" 18 android:id="@+id/article_headline"
19 android:layout_width="match_parent" 19 android:layout_width="match_parent"
20 android:layout_height="wrap_content" 20 android:layout_height="wrap_content"
21 android:layout_alignParentStart="true" 21 android:layout_alignParentStart="true"
22 android:layout_toStartOf="@+id/article_thumbnail" 22 android:layout_toStartOf="@+id/article_thumbnail"
23 android:ellipsize="end" 23 android:ellipsize="end"
24 android:textSize="16sp" 24 android:textSize="16sp"
25 android:textColor="@color/snippets_headline_text_color" 25 android:textColor="@color/snippets_headline_text_color"
26 chrome:leading="24dp" /> 26 chrome:leading="24sp" />
27 27
28 <org.chromium.ui.widget.TextViewWithLeading 28 <org.chromium.ui.widget.TextViewWithLeading
29 android:id="@+id/article_snippet" 29 android:id="@+id/article_snippet"
30 android:layout_width="match_parent" 30 android:layout_width="match_parent"
31 android:layout_height="wrap_content" 31 android:layout_height="wrap_content"
32 android:layout_alignParentStart="true" 32 android:layout_alignParentStart="true"
33 android:layout_below="@+id/article_headline" 33 android:layout_below="@+id/article_headline"
34 android:layout_toStartOf="@+id/article_thumbnail" 34 android:layout_toStartOf="@+id/article_thumbnail"
35 android:layout_marginTop="8dp" 35 android:layout_marginTop="8dp"
36 android:maxLines="2" 36 android:maxLines="2"
37 android:ellipsize="end" 37 android:ellipsize="end"
38 android:textSize="14sp" 38 android:textSize="14sp"
39 android:textColor="@color/snippets_text_color" 39 android:textColor="@color/snippets_text_color"
40 chrome:leading="20dp" /> 40 chrome:leading="20sp" />
41 41
42 <LinearLayout 42 <LinearLayout
43 tools:ignore="UseCompoundDrawables" 43 tools:ignore="UseCompoundDrawables"
44 android:id="@+id/publisher_bar" 44 android:id="@+id/publisher_bar"
45 android:layout_width="wrap_content" 45 android:layout_width="wrap_content"
46 android:layout_height="wrap_content" 46 android:layout_height="wrap_content"
47 android:layout_marginTop="@dimen/snippets_publisher_margin_top_with_arti cle_snippet" 47 android:layout_marginTop="@dimen/snippets_publisher_margin_top_with_arti cle_snippet"
48 android:layout_alignParentStart="true" 48 android:layout_alignParentStart="true"
49 android:layout_below="@+id/article_snippet" 49 android:layout_below="@+id/article_snippet"
50 android:orientation="horizontal"> 50 android:orientation="horizontal">
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 android:id="@+id/article_thumbnail" 100 android:id="@+id/article_thumbnail"
101 android:layout_width="@dimen/snippets_thumbnail_size" 101 android:layout_width="@dimen/snippets_thumbnail_size"
102 android:layout_height="@dimen/snippets_thumbnail_size" 102 android:layout_height="@dimen/snippets_thumbnail_size"
103 android:layout_alignParentTop="true" 103 android:layout_alignParentTop="true"
104 android:layout_alignParentEnd="true" 104 android:layout_alignParentEnd="true"
105 android:layout_marginStart="@dimen/snippets_thumbnail_margin" 105 android:layout_marginStart="@dimen/snippets_thumbnail_margin"
106 android:scaleType="centerCrop" 106 android:scaleType="centerCrop"
107 android:contentDescription="@null" 107 android:contentDescription="@null"
108 android:src="@null" /> 108 android:src="@null" />
109 </RelativeLayout> 109 </RelativeLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_card_large_thumbnail.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698