Stop depending on LabelElement(s) to be reported in visitChildren().

Stop depending on LabelElement(s) to be reported in visitChildren().

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6323bedc5898278c57b60b334b185326664f4d9d

[Brian Wilkerson, 2017-07-06 18:19:19]

I'd like to see less duplication, but otherwise lgtm.

https://codereview.chromium.org/2973093002/diff/1/pkg/analysis_server/test/pl...
File pkg/analysis_server/test/plugin/protocol_dart_test.dart (right):

https://codereview.chromium.org/2973093002/diff/1/pkg/analysis_server/test/pl...
pkg/analysis_server/test/plugin/protocol_dart_test.dart:31: List<engine.Element>
findElementsByName(
Can we use the copy in pkg/analyzer/test/utils.dart?

https://codereview.chromium.org/2973093002/diff/1/pkg/analysis_server/test/pl...
pkg/analysis_server/test/plugin/protocol_dart_test.dart:492: class
_ElementsByNameFinder extends engine.RecursiveAstVisitor<Null> {
Was this in an earlier CL? If so, perhaps create a shared copy.

https://codereview.chromium.org/2973093002/diff/1/pkg/analyzer_plugin/test/su...
File pkg/analyzer_plugin/test/support/abstract_context.dart (right):

https://codereview.chromium.org/2973093002/diff/1/pkg/analyzer_plugin/test/su...
pkg/analyzer_plugin/test/support/abstract_context.dart:47: List<Element>
findElementsByName(CompilationUnit unit, String name) {
Can we use the copy in pkg/analyzer/test/utils.dart?

[scheglov, 2017-07-06 18:28:12]

Description was changed from

==========
Stop depending on LabelElement(s) to be reported in visitChildren().

R=brianwilkerson@google.com
BUG=
==========

to

==========
Stop depending on LabelElement(s) to be reported in visitChildren().

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6323bedc5898278c57b60b334b185326664f4d9d
==========

[scheglov, 2017-07-06 18:28:14]

Committed patchset #1 (id:1) manually as
6323bedc5898278c57b60b334b185326664f4d9d (presubmit successful).