Stop depending on LabelElement(s) to be reported in visitChildren().

pkg/analyzer/test/src/dart/analysis/search_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/dart/analysis/search.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
 import 'package:analyzer/src/dart/element/member.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
+import '../../../utils.dart';
 import 'base.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(SearchTest);
   });
 }
 
 class ExpectedResult {
   final Element enclosingElement;
@@ skipping 538 matching lines @@
 main() {
 label:
   while (true) {
     if (true) {
       break label; // 1
     }
     break label; // 2
   }
 }
 ''');
-    Element element = _findElement('label');
+    Element element = findElementsByName(testUnit, 'label').single;
     Element main = _findElement('main');
     var expected = [
       _expectId(main, SearchResultKind.REFERENCE, 'label; // 1'),
       _expectId(main, SearchResultKind.REFERENCE, 'label; // 2')
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_LibraryElement() async {
     var codeA = 'part of lib; // A';
@@ skipping 20 matching lines @@
   test_searchReferences_LocalVariableElement() async {
     await _resolveTestUnit(r'''
 main() {
   var v;
   v = 1;
   v += 2;
   print(v);
   v();
 }
 ''');
-    Element element = _findElementAtString('v;');
+    Element element = findElementsByName(testUnit, 'v').single;
     Element main = _findElement('main');
     var expected = [
       _expectId(main, SearchResultKind.WRITE, 'v = 1;'),
       _expectId(main, SearchResultKind.READ_WRITE, 'v += 2;'),
       _expectId(main, SearchResultKind.READ, 'v);'),
       _expectId(main, SearchResultKind.INVOCATION, 'v();')
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_localVariableElement_inForEachLoop() async {
     await _resolveTestUnit('''
 main() {
   for (var v in []) {
     v = 1;
     v += 2;
     print(v);
     v();
   }
 }
 ''');
-    Element element = _findElementAtString('v in []');
+    Element element = findElementsByName(testUnit, 'v').single;
     Element main = _findElement('main');
     var expected = [
       _expectId(main, SearchResultKind.WRITE, 'v = 1;'),
       _expectId(main, SearchResultKind.READ_WRITE, 'v += 2;'),
       _expectId(main, SearchResultKind.READ, 'v);'),
       _expectId(main, SearchResultKind.INVOCATION, 'v();')
     ];
     await _verifyReferences(element, expected);
   }
 
@@ skipping 615 matching lines @@
     List<SearchResult> results = await driver.search.references(element);
     _assertResults(results, expectedMatches);
     expect(results, hasLength(expectedMatches.length));
   }
 
   static void _assertResults(
       List<SearchResult> matches, List<ExpectedResult> expectedMatches) {
     expect(matches, unorderedEquals(expectedMatches));
   }
 }