Stop depending on LabelElement(s) to be reported in visitChildren().

pkg/analyzer_plugin/test/utilities/analyzer_converter_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/ast/ast.dart' as analyzer;
 import 'package:analyzer/dart/element/element.dart' as analyzer;
 import 'package:analyzer/dart/element/type.dart' as analyzer;
 import 'package:analyzer/error/error.dart' as analyzer;
 import 'package:analyzer/exception/exception.dart' as analyzer;
 import 'package:analyzer/source/error_processor.dart' as analyzer;
@@ skipping 336 matching lines @@
         expect(location.length, 'three'.length);
         expect(location.startLine, 3);
         expect(location.startColumn, 11);
       }
       expect(element.parameters, isNull);
       expect(element.returnType, 'E2');
       expect(element.flags,
           plugin.Element.FLAG_CONST | plugin.Element.FLAG_STATIC);
     }
     {
-      analyzer.FieldElement engineElement = findElementInUnit(unit, 'index');
+      analyzer.FieldElement engineElement =
+          unit.element.enums[1].getField('index');
       // create notification Element
       plugin.Element element = converter.convertElement(engineElement);
       expect(element.kind, plugin.ElementKind.FIELD);
       expect(element.name, 'index');
       {
         plugin.Location location = element.location;
         expect(location.file, testFile);
         expect(location.offset, -1);
         expect(location.length, 'index'.length);
         expect(location.startLine, 1);
         expect(location.startColumn, 0);
       }
       expect(element.parameters, isNull);
       expect(element.returnType, 'int');
       expect(element.flags, plugin.Element.FLAG_FINAL);
     }
     {
-      analyzer.FieldElement engineElement = findElementInUnit(unit, 'values');
+      analyzer.FieldElement engineElement =
+          unit.element.enums[1].getField('values');
+
       // create notification Element
       plugin.Element element = converter.convertElement(engineElement);
       expect(element.kind, plugin.ElementKind.FIELD);
       expect(element.name, 'values');
       {
         plugin.Location location = element.location;
         expect(location.file, testFile);
         expect(location.offset, -1);
         expect(location.length, 'values'.length);
         expect(location.startLine, 1);
@@ skipping 116 matching lines @@
   }
 
   test_convertElement_setter() async {
     analyzer.Source source = addSource(
         testFile,
         '''
 class A {
   set mySetter(String x) {}
 }''');
     analyzer.CompilationUnit unit = await resolveLibraryUnit(source);
-    analyzer.FieldElement engineFieldElement =
-        findElementInUnit(unit, 'mySetter', analyzer.ElementKind.FIELD);
-    analyzer.PropertyAccessorElement engineElement = engineFieldElement.setter;
+    analyzer.PropertyAccessorElement engineElement =
+        findElementInUnit(unit, 'mySetter', analyzer.ElementKind.SETTER);
     // create notification Element
     plugin.Element element = converter.convertElement(engineElement);
     expect(element.kind, plugin.ElementKind.SETTER);
     expect(element.name, 'mySetter');
     {
       plugin.Location location = element.location;
       expect(location.file, testFile);
       expect(location.offset, 16);
       expect(location.length, 'mySetter'.length);
       expect(location.startLine, 2);
@@ skipping 76 matching lines @@
       expect(location.offset, 9);
       expect(location.length, 'myLabel'.length);
       expect(location.startLine, 2);
       expect(location.startColumn, 1);
     }
     expect(element.parameters, isNull);
     expect(element.returnType, isNull);
     expect(element.flags, 0);
   }
 }