Stop depending on LabelElement(s) to be reported in visitChildren().

pkg/analysis_server/test/plugin/protocol_dart_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/plugin/protocol/protocol_dart.dart';
 import 'package:analyzer/dart/ast/ast.dart' as engine;
 import 'package:analyzer/dart/ast/visitor.dart' as engine;
 import 'package:analyzer/dart/element/element.dart' as engine;
 import 'package:analyzer/dart/element/type.dart' as engine;
 import 'package:analyzer/error/error.dart' as engine;
 import 'package:analyzer/src/dart/ast/utilities.dart' as engine;
 import 'package:analyzer/src/dart/element/element.dart' as engine;
 import 'package:analyzer/src/error/codes.dart' as engine;
 import 'package:analyzer/src/generated/source.dart' as engine;
 import 'package:analyzer_plugin/protocol/protocol_common.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../abstract_context.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(ElementTest);
     defineReflectiveTests(ElementKindTest);
   });
 }
 
+/**
+ * Search the [unit] for the [engine.Element]s with the given [name].
+ */
+List<engine.Element> findElementsByName(

[Brian Wilkerson, 2017/07/06 18:19:18]

Can we use the copy in pkg/analyzer/test/utils.dart?

+    engine.CompilationUnit unit, String name) {
+  var finder = new _ElementsByNameFinder(name);
+  unit.accept(finder);
+  return finder.elements;
+}
+
 @reflectiveTest
 class ElementKindTest {
   void test_fromEngine() {
     expect(convertElementKind(engine.ElementKind.CLASS), ElementKind.CLASS);
     expect(convertElementKind(engine.ElementKind.COMPILATION_UNIT),
         ElementKind.COMPILATION_UNIT);
     expect(convertElementKind(engine.ElementKind.CONSTRUCTOR),
         ElementKind.CONSTRUCTOR);
     expect(convertElementKind(engine.ElementKind.FIELD), ElementKind.FIELD);
     expect(
@@ skipping 52 matching lines @@
     expect(ElementKind.CLASS.toString(), 'ElementKind.CLASS');
     expect(ElementKind.COMPILATION_UNIT.toString(),
         'ElementKind.COMPILATION_UNIT');
   }
 }
 
 @reflectiveTest
 class ElementTest extends AbstractContextTest {
   engine.Element findElementInUnit(engine.CompilationUnit unit, String name,
       [engine.ElementKind kind]) {
-    return findChildElement(unit.element, name, kind);
+    return findElementsByName(unit, name)
+        .where((e) => kind == null || e.kind == kind)
+        .single;
   }
 
   test_fromElement_CLASS() async {
     engine.Source source = addSource(
         '/test.dart',
         '''
 @deprecated
 abstract class _A {}
 class B<K, V> {}''');
     engine.CompilationUnit unit = await resolveLibraryUnit(source);
@@ skipping 155 matching lines @@
         expect(location.offset, 44);
         expect(location.length, 'three'.length);
         expect(location.startLine, 3);
         expect(location.startColumn, 11);
       }
       expect(element.parameters, isNull);
       expect(element.returnType, 'E2');
       expect(element.flags, Element.FLAG_CONST | Element.FLAG_STATIC);
     }
     {
-      engine.FieldElement engineElement = findElementInUnit(unit, 'index');
+      engine.FieldElement engineElement =
+          unit.element.enums[1].getField('index');
       // create notification Element
       Element element = convertElement(engineElement);
       expect(element.kind, ElementKind.FIELD);
       expect(element.name, 'index');
       {
         Location location = element.location;
         expect(location.file, '/test.dart');
         expect(location.offset, -1);
         expect(location.length, 'index'.length);
         expect(location.startLine, 1);
         expect(location.startColumn, 0);
       }
       expect(element.parameters, isNull);
       expect(element.returnType, 'int');
       expect(element.flags, Element.FLAG_FINAL);
     }
     {
-      engine.FieldElement engineElement = findElementInUnit(unit, 'values');
+      engine.FieldElement engineElement =
+          unit.element.enums[1].getField('values');
       // create notification Element
       Element element = convertElement(engineElement);
       expect(element.kind, ElementKind.FIELD);
       expect(element.name, 'values');
       {
         Location location = element.location;
         expect(location.file, '/test.dart');
         expect(location.offset, -1);
         expect(location.length, 'values'.length);
         expect(location.startLine, 1);
@@ skipping 143 matching lines @@
   }
 
   test_fromElement_SETTER() async {
     engine.Source source = addSource(
         '/test.dart',
         '''
 class A {
   set mySetter(String x) {}
 }''');
     engine.CompilationUnit unit = await resolveLibraryUnit(source);
-    engine.FieldElement engineFieldElement =
-        findElementInUnit(unit, 'mySetter', engine.ElementKind.FIELD);
-    engine.PropertyAccessorElement engineElement = engineFieldElement.setter;
+    engine.PropertyAccessorElement engineElement =
+        findElementInUnit(unit, 'mySetter', engine.ElementKind.SETTER);
     // create notification Element
     Element element = convertElement(engineElement);
     expect(element.kind, ElementKind.SETTER);
     expect(element.name, 'mySetter');
     {
       Location location = element.location;
       expect(location.file, '/test.dart');
       expect(location.offset, 16);
       expect(location.length, 'mySetter'.length);
       expect(location.startLine, 2);
       expect(location.startColumn, 7);
     }
     expect(element.parameters, '(String x)');
     expect(element.returnType, isNull);
     expect(element.flags, 0);
   }
 }
+
+class _ElementsByNameFinder extends engine.RecursiveAstVisitor<Null> {

[Brian Wilkerson, 2017/07/06 18:19:18]

Was this in an earlier CL? If so, perhaps create a shared copy.

+  final String name;
+  final List<engine.Element> elements = [];
+
+  _ElementsByNameFinder(this.name);
+
+  @override
+  visitSimpleIdentifier(engine.SimpleIdentifier node) {
+    if (node.name == name && node.inDeclarationContext()) {
+      elements.add(node.staticElement);
+    }
+  }
+}