Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2972933002: [Media Router] Move main frame check for SetDefaultPresentationUrls. (Closed)

Created:
3 years, 5 months ago by imcheng
Modified:
3 years, 5 months ago
Reviewers:
mark a. foltz, zhaobin
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, jam, mfoltz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Move main frame check for SetDefaultPresentationUrls. Move the check to PSImpl since we are already doing a main frame check there and it's slightly simpler. BUG=736557 Review-Url: https://codereview.chromium.org/2972933002 Cr-Commit-Position: refs/heads/master@{#485724} Committed: https://chromium.googlesource.com/chromium/src/+/22578daaf51705107a2519f0209e9ceec3358a38

Patch Set 1 : . #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -25 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 1 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
imcheng
Bin: PTAL, thanks!
3 years, 5 months ago (2017-07-07 17:49:36 UTC) #3
zhaobin
lgtm
3 years, 5 months ago (2017-07-07 17:52:17 UTC) #4
imcheng
+mfoltz for committers, thanks!
3 years, 5 months ago (2017-07-11 05:16:30 UTC) #6
mark a. foltz
lgtm
3 years, 5 months ago (2017-07-11 17:36:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972933002/40001
3 years, 5 months ago (2017-07-11 17:48:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/498131)
3 years, 5 months ago (2017-07-11 19:35:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972933002/40001
3 years, 5 months ago (2017-07-11 19:41:31 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 23:09:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/22578daaf51705107a2519f0209e...

Powered by Google App Engine
This is Rietveld 408576698