Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2972933002: [Media Router] Move main frame check for SetDefaultPresentationUrls. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h" 5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/test/mock_callback.h" 8 #include "base/test/mock_callback.h"
9 #include "chrome/browser/media/router/mock_media_router.h" 9 #include "chrome/browser/media/router/mock_media_router.h"
10 #include "chrome/browser/media/router/mock_screen_availability_listener.h" 10 #include "chrome/browser/media/router/mock_screen_availability_listener.h"
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 TEST_F(PresentationServiceDelegateImplTest, AddListenerForInvalidUrl) { 327 TEST_F(PresentationServiceDelegateImplTest, AddListenerForInvalidUrl) {
328 MockScreenAvailabilityListener listener(GURL("unsupported-url://foo")); 328 MockScreenAvailabilityListener listener(GURL("unsupported-url://foo"));
329 EXPECT_CALL(listener, 329 EXPECT_CALL(listener,
330 OnScreenAvailabilityChanged( 330 OnScreenAvailabilityChanged(
331 blink::mojom::ScreenAvailability::SOURCE_NOT_SUPPORTED)); 331 blink::mojom::ScreenAvailability::SOURCE_NOT_SUPPORTED));
332 EXPECT_FALSE(delegate_impl_->AddScreenAvailabilityListener( 332 EXPECT_FALSE(delegate_impl_->AddScreenAvailabilityListener(
333 main_frame_process_id_, main_frame_routing_id_, &listener)); 333 main_frame_process_id_, main_frame_routing_id_, &listener));
334 EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).Times(0); 334 EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).Times(0);
335 } 335 }
336 336
337 // TODO(imcheng): Add a test to set default presentation URL in a different
338 // RenderFrameHost and verify that it is ignored.
339 TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) { 337 TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) {
340 EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest()); 338 EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest());
341 339
342 GURL frame_url(kFrameUrl); 340 GURL frame_url(kFrameUrl);
343 content::WebContentsTester::For(GetWebContents()) 341 content::WebContentsTester::For(GetWebContents())
344 ->NavigateAndCommit(frame_url); 342 ->NavigateAndCommit(frame_url);
345 343
346 auto callback = base::Bind( 344 auto callback = base::Bind(
347 &PresentationServiceDelegateImplTest::OnDefaultPresentationStarted, 345 &PresentationServiceDelegateImplTest::OnDefaultPresentationStarted,
348 base::Unretained(this)); 346 base::Unretained(this));
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 base::Bind(&MockCreatePresentationConnnectionCallbacks:: 788 base::Bind(&MockCreatePresentationConnnectionCallbacks::
791 OnCreateConnectionSuccess, 789 OnCreateConnectionSuccess,
792 base::Unretained(&mock_create_connection_callbacks)), 790 base::Unretained(&mock_create_connection_callbacks)),
793 base::Bind( 791 base::Bind(
794 &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, 792 &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
795 base::Unretained(&mock_create_connection_callbacks))); 793 base::Unretained(&mock_create_connection_callbacks)));
796 } 794 }
797 #endif // !defined(OS_ANDROID) 795 #endif // !defined(OS_ANDROID)
798 796
799 } // namespace media_router 797 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698