chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc - Issue 2972933002: [Media Router] Move main frame check for SetDefaultPresentationUrls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2972933002: [Media Router] Move main frame check for SetDefaultPresentationUrls. (Closed)

Patch Set: Rebase Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | content/browser/presentation/presentation_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

index c18a5cec3de6c5cdbdd03f064fa580a07fe48acb..16e86a50ba70a7821606bee069b107d35e182a7c 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

@@ -334,8 +334,6 @@ TEST_F(PresentationServiceDelegateImplTest, AddListenerForInvalidUrl) {

EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).Times(0);

}

-// TODO(imcheng): Add a test to set default presentation URL in a different

-// RenderFrameHost and verify that it is ignored.

TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) {

EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest());