Mac: Fix up location bar decoration bubble anchoring.

Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.

Screenshots: http://crbug.com/77157#c18

BUG=77157, 635172
Review-Url: https://codereview.chromium.org/2972593002
Cr-Commit-Position: refs/heads/master@{#484420}
Committed: https://chromium.googlesource.com/chromium/src/+/c06fedb0d6a4463cc87ffd6e67375124f9c8426a

[tapted, 2017-07-04 04:45:08]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 04:45:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-07-04 04:50:34]

Description was changed from

==========
Position to the location bar


Position the same

BUG=77157
==========

to

==========
Mac: Fix up location decoration bubble anchoring.



BUG=77157, 635172
==========

[tapted, 2017-07-04 04:57:28]

Description was changed from

==========
Mac: Fix up location decoration bubble anchoring.



BUG=77157, 635172
==========

to

==========
Mac: Fix up location decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration. Fix by
consolidating codepaths for obtaining the anchor from LocationBarView.

BUG=77157, 635172
==========

[tapted, 2017-07-04 04:57:28]

tapted@chromium.org changed reviewers:
+ ellyjones@chromium.org

[tapted, 2017-07-04 04:57:44]

Description was changed from

==========
Mac: Fix up location decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration. Fix by
consolidating codepaths for obtaining the anchor from LocationBarView.

BUG=77157, 635172
==========

to

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration. Fix by
consolidating codepaths for obtaining the anchor from LocationBarView.

BUG=77157, 635172
==========

[tapted, 2017-07-04 04:58:26]

Description was changed from

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration. Fix by
consolidating codepaths for obtaining the anchor from LocationBarView.

BUG=77157, 635172
==========

to

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.

BUG=77157, 635172
==========

[tapted, 2017-07-04 04:59:41]

Description was changed from

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.

BUG=77157, 635172
==========

to

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.

Screenshots: http://crbug.com/77157#c18

BUG=77157, 635172
==========

[commit-bot: I haz the power, 2017-07-04 05:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 05:22:17]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-07-04 05:23:14]

Hi Elly, please take a look

[Elly Fong-Jones, 2017-07-05 13:38:43]

lgtm! :)

[tapted, 2017-07-06 00:13:48]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-07-06 00:14:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 00:34:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499300028739690, "parent_rev":
"eb6eb71751ad10cb2d20249b058ecb7265c746d1", "commit_rev":
"c06fedb0d6a4463cc87ffd6e67375124f9c8426a"}

[commit-bot: I haz the power, 2017-07-06 00:34:31]

Description was changed from

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.

Screenshots: http://crbug.com/77157#c18

BUG=77157, 635172
==========

to

==========
Mac: Fix up location bar decoration bubble anchoring.

Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.

Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.

With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.

Screenshots: http://crbug.com/77157#c18

BUG=77157, 635172

Review-Url: https://codereview.chromium.org/2972593002
Cr-Commit-Position: refs/heads/master@{#484420}
Committed:
https://chromium.googlesource.com/chromium/src/+/c06fedb0d6a4463cc87ffd6e6737...
==========

[commit-bot: I haz the power, 2017-07-06 00:34:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c06fedb0d6a4463cc87ffd6e6737...