Chromium Code Reviews
DescriptionMac: Fix up location bar decoration bubble anchoring.
Content settings bubbles currently anchor wrong both with and without
--secondary-ui-md.
Without --secondary-ui-md the y-offset just needs to match the bookmark
star. Expose StarDecoration::GetStarBubblePointInFrame() for this.
With --secondary-ui-md the bubble should anchor to the corner of the
location bar frame. This was also slightly off for the bookmark star,
which currently anchors to the location icon decoration hover
background. Fix by consolidating codepaths for obtaining the anchor from
LocationBarView.
Screenshots: http://crbug.com/77157#c18
BUG=77157, 635172
Review-Url: https://codereview.chromium.org/2972593002
Cr-Commit-Position: refs/heads/master@{#484420}
Committed: https://chromium.googlesource.com/chromium/src/+/c06fedb0d6a4463cc87ffd6e67375124f9c8426a
Patch Set 1 #
Messages
Total messages: 17 (13 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||