Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

Issue 2972593002: Mac: Fix up location bar decoration bubble anchoring. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
index 00a78454ae71680e2c627b47c053a1f58a145486..9e9dc9bad7bdc58bd7800fc4fc738cb0168323f8 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
@@ -291,13 +291,10 @@ const CGFloat kAnimationDuration = 0.2;
if (!ui::MaterialDesignController::IsSecondaryUiMaterial())
return [self arrowAnchorPointForDecoration:decoration];
- // Under MD, dialogs have no arrow and anchor to corner of the decoration
+ // Under MD, dialogs have no arrow and anchor to corner of the location bar
// frame, not a specific point within it. See http://crbug.com/566115.
- BOOL isLeftDecoration;
- const NSRect frame =
- [[self cell] backgroundFrameForDecoration:decoration
- inFrame:[self bounds]
- isLeftDecoration:&isLeftDecoration];
+ BOOL isLeftDecoration = [[self cell] isLeftDecoration:decoration];
+ const NSRect frame = [self bounds];
NSPoint point = NSMakePoint(isLeftDecoration ? NSMinX(frame) : NSMaxX(frame),
NSMaxY(frame));
return [self convertPoint:point toView:nil];
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698