Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4719)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

Issue 2972593002: Mac: Fix up location bar decoration bubble anchoring. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
index 5edf8f3e4adebc3d65defb41be35bb0bdfba6789..4f74bb5abe60d470b6d14a168c17218a6cf975ba 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
@@ -274,16 +274,11 @@ size_t CalculatePositionsInFrame(
return NSZeroRect;
}
-- (NSRect)backgroundFrameForDecoration:(LocationBarDecoration*)decoration
- inFrame:(NSRect)cellFrame
- isLeftDecoration:(BOOL*)isLeftDecoration {
- NSRect decorationFrame =
- [self frameForDecoration:decoration inFrame:cellFrame];
+- (BOOL)isLeftDecoration:(LocationBarDecoration*)decoration {
std::vector<LocationBarDecoration*>& left_decorations =
cocoa_l10n_util::ShouldDoExperimentalRTLLayout() ? trailingDecorations_
: leadingDecorations_;
- *isLeftDecoration = base::ContainsValue(left_decorations, decoration);
- return decoration->GetBackgroundFrame(decorationFrame);
+ return base::ContainsValue(left_decorations, decoration);
}
// Overriden to account for the decorations.

Powered by Google App Engine
This is Rietveld 408576698