[devil] Extract logging common behavior to its own module.

[devil] Extract logging common behavior to its own module.

Also deprecates the now-poorly-named run_tests_helper.py.

Review-Url: https://codereview.chromium.org/2972253002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/18709dd6bd88aee18994e1570754e0a1bb92bea4

[jbudorick, 2017-07-07 18:05:06]

jbudorick@chromium.org changed reviewers:
+ bpastene@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2017-07-07 18:43:18]

lgtm w/ question

https://codereview.chromium.org/2972253002/diff/20001/devil/devil/utils/loggi...
File devil/devil/utils/logging_common.py (right):

https://codereview.chromium.org/2972253002/diff/20001/devil/devil/utils/loggi...
devil/devil/utils/logging_common.py:12: DEFAULT = object()
Couldn't callers just pass in logging.NullHandler() if they didnt want a
handler?
Or is there a difference between literally not setting a handler and setting
NullHandler?

[jbudorick, 2017-07-07 23:06:53]

https://codereview.chromium.org/2972253002/diff/20001/devil/devil/utils/loggi...
File devil/devil/utils/logging_common.py (right):

https://codereview.chromium.org/2972253002/diff/20001/devil/devil/utils/loggi...
devil/devil/utils/logging_common.py:12: DEFAULT = object()
On 2017/07/07 18:43:18, mikecase wrote:
> Couldn't callers just pass in logging.NullHandler() if they didnt want a
> handler?
> Or is there a difference between literally not setting a handler and setting
> NullHandler?

hmm, I suppose that could work. I had been trying to maintain parity between
SetLogLevel(..., add_handler=False) until I get to switch over test_runner.py,
but NullHandler could be ok.

[jbudorick, 2017-08-10 14:21:52]

https://codereview.chromium.org/2972253002/diff/20001/devil/devil/utils/loggi...
File devil/devil/utils/logging_common.py (right):

https://codereview.chromium.org/2972253002/diff/20001/devil/devil/utils/loggi...
devil/devil/utils/logging_common.py:12: DEFAULT = object()
On 2017/07/07 23:06:52, jbudorick wrote:
> On 2017/07/07 18:43:18, mikecase wrote:
> > Couldn't callers just pass in logging.NullHandler() if they didnt want a
> > handler?
> > Or is there a difference between literally not setting a handler and setting
> > NullHandler?
> 
> hmm, I suppose that could work. I had been trying to maintain parity between
> SetLogLevel(..., add_handler=False) until I get to switch over test_runner.py,
> but NullHandler could be ok.

Done.

[jbudorick, 2017-08-10 14:21:54]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2017-08-10 14:21:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2972253002/#ps40001
(title: "mikecase comments and rebase")

[commit-bot: I haz the power, 2017-08-10 14:22:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-10 14:49:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1502374914620590,
"parent_rev": "0eeb5baed7a4417ac083221805842019185ccec0", "commit_rev":
"18709dd6bd88aee18994e1570754e0a1bb92bea4"}

[commit-bot: I haz the power, 2017-08-10 14:49:42]

Description was changed from

==========
[devil] Extract logging common behavior to its own module.

Also deprecates the now-poorly-named run_tests_helper.py.
==========

to

==========
[devil] Extract logging common behavior to its own module.

Also deprecates the now-poorly-named run_tests_helper.py.

Review-Url: https://codereview.chromium.org/2972253002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-10 14:49:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[perezju, 2017-08-11 08:00:20]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2998833002/ by perezju@chromium.org.

The reason for reverting is: Appears to be blocking catapult roller. Tests are
failing with, e.g.:

Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/test_runner.py", line 34, in <module>
    from devil.utils import run_tests_helper
  File
"/b/swarming/w/ir/third_party/catapult/devil/devil/utils/run_tests_helper.py",
line 10, in <module>
    from devil.utils import logging_common
ImportError: cannot import name logging_common
[E2017-08-10T18:17:37.717840Z 31228 0 subcommand_run.go:333] Command completed
with non-zero return code. {"returnCode":1}
[I2017-08-10T18:17:37.718115Z 31228 0 main.go:349] Terminating.                 
              {"returnCode":1}

https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_....