Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: devil/devil/android/tools/cpufreq.py

Issue 2972253002: [devil] Extract logging common behavior to its own module. (Closed)
Patch Set: mikecase comments and rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « devil/devil/android/tools/adb_run_shell_cmd.py ('k') | devil/devil/android/tools/device_recovery.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devil/devil/android/tools/cpufreq.py
diff --git a/devil/devil/android/tools/cpufreq.py b/devil/devil/android/tools/cpufreq.py
index 8eb0fbd2b4f1ed864e133cac487a3a27e1b326df..6ce0affdc26f16f9d1dcfe8f07184e39b417e5be 100755
--- a/devil/devil/android/tools/cpufreq.py
+++ b/devil/devil/android/tools/cpufreq.py
@@ -18,7 +18,7 @@ if __name__ == '__main__':
from devil.android import device_utils
from devil.android.perf import perf_control
from devil.android.tools import script_common
-from devil.utils import run_tests_helper
+from devil.utils import logging_common
def SetScalingGovernor(device, args):
@@ -40,13 +40,11 @@ def ListAvailableGovernors(device, _args):
def main(raw_args):
parser = argparse.ArgumentParser()
+ logging_common.AddLoggingArguments(parser)
script_common.AddEnvironmentArguments(parser)
parser.add_argument(
'--device', dest='devices', action='append', default=[],
help='Devices for which the governor should be set. Defaults to all.')
- parser.add_argument(
- '-v', '--verbose', action='count',
- help='Log more.')
subparsers = parser.add_subparsers()
@@ -64,7 +62,7 @@ def main(raw_args):
args = parser.parse_args(raw_args)
- run_tests_helper.SetLogLevel(args.verbose)
+ logging_common.InitializeLogging(args)
script_common.InitializeEnvironment(args)
devices = device_utils.DeviceUtils.HealthyDevices(device_arg=args.devices)
« no previous file with comments | « devil/devil/android/tools/adb_run_shell_cmd.py ('k') | devil/devil/android/tools/device_recovery.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698