Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: devil/devil/android/tools/keyboard.py

Issue 2972253002: [devil] Extract logging common behavior to its own module. (Closed)
Patch Set: mikecase comments and rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « devil/devil/android/tools/flash_device.py ('k') | devil/devil/android/tools/provision_devices.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devil/devil/android/tools/keyboard.py
diff --git a/devil/devil/android/tools/keyboard.py b/devil/devil/android/tools/keyboard.py
index 3a74692680c3062fd8558f5f504e1486664bc552..c5cb6149099aad9cf43273be58ad61449ee68b3a 100755
--- a/devil/devil/android/tools/keyboard.py
+++ b/devil/devil/android/tools/keyboard.py
@@ -19,7 +19,7 @@ if __name__ == '__main__':
from devil import base_error
from devil.android.sdk import keyevent
from devil.android.tools import script_common
-from devil.utils import run_tests_helper
+from devil.utils import logging_common
_KEY_MAPPING = {
@@ -89,11 +89,11 @@ class MultipleDevicesError(base_error.BaseError):
def main(raw_args):
parser = argparse.ArgumentParser(
description="Use your keyboard as your phone's keyboard.")
+ logging_common.AddLoggingArguments(parser)
script_common.AddDeviceArguments(parser)
- parser.add_argument('-v', '--verbose', action='count', help='print more')
args = parser.parse_args(raw_args)
- run_tests_helper.SetLogLevel(args.verbose)
+ logging_common.InitializeLogging(args)
devices = script_common.GetDevices(args.devices, None)
if len(devices) > 1:
« no previous file with comments | « devil/devil/android/tools/flash_device.py ('k') | devil/devil/android/tools/provision_devices.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698