Add a temporary check to investigate NavigationThrottle crash

Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2971833002
Cr-Commit-Position: refs/heads/master@{#484363}
Committed: https://chromium.googlesource.com/chromium/src/+/a9f628ff52bffcfcae37a669c8bae5da1c560364

[clamy, 2017-07-05 15:39:47]

Description was changed from

==========
Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
==========

to

==========
Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-07-05 15:43:22]

Description was changed from

==========
Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-07-05 15:43:22]

clamy@chromium.org changed reviewers:
+ csharrison@chromium.org

[clamy, 2017-07-05 15:43:36]

@csharrison: PTAL.

[Charlie Harrison, 2017-07-05 16:55:25]

LGTM I really appreciate your help here :)

[Charlie Harrison, 2017-07-05 17:35:22]

I think you've gone home for the day but it would be nice to get this in by
tonights Canary.

I hope you don't mind that I send this to the CQ now.

[Charlie Harrison, 2017-07-05 17:35:27]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-07-05 17:35:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 21:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 21:18:59]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Charlie Harrison, 2017-07-05 21:21:24]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-07-05 21:21:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 22:15:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499289684170730, "parent_rev":
"23c426581c639f079e9f99d1595bd9a67b144c0c", "commit_rev":
"a9f628ff52bffcfcae37a669c8bae5da1c560364"}

[commit-bot: I haz the power, 2017-07-05 22:15:31]

Description was changed from

==========
Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a temporary check to investigate NavigationThrottle crash

This CL adds a temporay check to ensure we're not trying to add
NavigationThrottles to a NavigationHandle twice. This is part of the
investigation of several crashes around subresource filters
NavigationThrottles.

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2971833002
Cr-Commit-Position: refs/heads/master@{#484363}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9f628ff52bffcfcae37a669c8ba...
==========

[commit-bot: I haz the power, 2017-07-05 22:15:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9f628ff52bffcfcae37a669c8ba...

[clamy, 2017-07-06 14:58:20]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2968193002/ by clamy@chromium.org.

The reason for reverting is: We collected the data we needed..