Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2971833002: Add a temporary check to investigate NavigationThrottle crash (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 9e6c1fc1bd3e8a03ad3babb122673881e34a2ad4..388143d8c9dcccd32a880bde90fba7bc11dd2eef 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -1091,6 +1091,11 @@ void NavigationHandleImpl::RunCompleteCallback(
}
void NavigationHandleImpl::RegisterNavigationThrottles() {
+ // TODO(clamy): Remove this when we understand the root cause behind
+ // crbug.com/736658.
+ CHECK(!throttles_have_been_added_);
+ throttles_have_been_added_ = true;
+
// Register the navigation throttles. The vector returned by
// CreateThrottlesForNavigation is not assigned to throttles_ directly because
// it would overwrite any throttles previously added with
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698