Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2968193002: Revert of Add a temporary check to investigate NavigationThrottle crash (Closed)

Created:
3 years, 5 months ago by clamy
Modified:
3 years, 5 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a temporary check to investigate NavigationThrottle crash (patchset #1 id:1 of https://codereview.chromium.org/2971833002/ ) Reason for revert: We collected the data we needed. Original issue's description: > Add a temporary check to investigate NavigationThrottle crash > > This CL adds a temporay check to ensure we're not trying to add > NavigationThrottles to a NavigationHandle twice. This is part of the > investigation of several crashes around subresource filters > NavigationThrottles. > > BUG=736658 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2971833002 > Cr-Commit-Position: refs/heads/master@{#484363} > Committed: https://chromium.googlesource.com/chromium/src/+/a9f628ff52bffcfcae37a669c8bae5da1c560364 TBR=csharrison@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=736658 Review-Url: https://codereview.chromium.org/2968193002 Cr-Commit-Position: refs/heads/master@{#484592} Committed: https://chromium.googlesource.com/chromium/src/+/bee05730effbd6abf793a9d15f4379a1181a45cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
clamy
Created Revert of Add a temporary check to investigate NavigationThrottle crash
3 years, 5 months ago (2017-07-06 14:58:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968193002/1
3 years, 5 months ago (2017-07-06 14:58:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bee05730effbd6abf793a9d15f4379a1181a45cf
3 years, 5 months ago (2017-07-06 14:59:11 UTC) #6
Charlie Harrison
3 years, 5 months ago (2017-07-06 15:00:24 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698