SafeBrowsing test for WebSocket connection from worker

SafeBrowsing test for WebSocket connection from worker

Only WebSocket connections from the main page were tested. WebSocket connections
from Workers should also lead to display of an interstitial.

Modify malware_websocket.html to accept a "type" query parameter indicating
which environment to create the WebSocket in. Make the MalwareWebSocketBlocked
tests be parameterised on the environment type.

Due to a recent change (https://codereview.chromium.org/2960703003), these
changes need to be tested by passing --enable-features=NetworkService to
browser_tests, as opposed to the --enable-network-service argument that was
needed before.

BUG=644744
Review-Url: https://codereview.chromium.org/2971333002
Cr-Commit-Position: refs/heads/master@{#488151}
Committed: https://chromium.googlesource.com/chromium/src/+/0ddd2a9b99d89c93a354738181d1918796e5e2a2

[Adam Rice, 2017-07-07 14:37:01]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 14:37:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-07-07 14:59:45]

ricea@chromium.org changed reviewers:
+ vakh@chromium.org

[commit-bot: I haz the power, 2017-07-07 16:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 16:00:29]

Dry run: This issue passed the CQ dry run.

[vakh (use Gerrit instead), 2017-07-19 16:41:51]

lgtm

[Adam Rice, 2017-07-20 05:23:21]

Description was changed from

==========
SafeBrowsing test for WebSocket connection from worker

Only WebSocket connections from the main page were tested. WebSocket connections
from Workers should also lead to display of an intersitial.

Modify malware_websocket.html to accept a "type" query parameter indicating
which environment to create the WebSocket in. Make the MalwareWebSocketBlocked
tests be parameterised on the environment type.

Due to a recent change (https://codereview.chromium.org/2960703003), these
changes need to be tested by passing --enable-features=NetworkService to
browser_tests, as opposed to the --enable-network-service argument that was
needed before.

BUG=644744
==========

to

==========
SafeBrowsing test for WebSocket connection from worker

Only WebSocket connections from the main page were tested. WebSocket connections
from Workers should also lead to display of an interstitial.

Modify malware_websocket.html to accept a "type" query parameter indicating
which environment to create the WebSocket in. Make the MalwareWebSocketBlocked
tests be parameterised on the environment type.

Due to a recent change (https://codereview.chromium.org/2960703003), these
changes need to be tested by passing --enable-features=NetworkService to
browser_tests, as opposed to the --enable-network-service argument that was
needed before.

BUG=644744
==========

[Adam Rice, 2017-07-20 05:23:26]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2017-07-20 05:23:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 06:37:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1500528206947290, "parent_rev":
"36debc58c81094f47e733cf951afbd96c1ef4070", "commit_rev":
"0ddd2a9b99d89c93a354738181d1918796e5e2a2"}

[commit-bot: I haz the power, 2017-07-20 06:38:11]

Description was changed from

==========
SafeBrowsing test for WebSocket connection from worker

Only WebSocket connections from the main page were tested. WebSocket connections
from Workers should also lead to display of an interstitial.

Modify malware_websocket.html to accept a "type" query parameter indicating
which environment to create the WebSocket in. Make the MalwareWebSocketBlocked
tests be parameterised on the environment type.

Due to a recent change (https://codereview.chromium.org/2960703003), these
changes need to be tested by passing --enable-features=NetworkService to
browser_tests, as opposed to the --enable-network-service argument that was
needed before.

BUG=644744
==========

to

==========
SafeBrowsing test for WebSocket connection from worker

Only WebSocket connections from the main page were tested. WebSocket connections
from Workers should also lead to display of an interstitial.

Modify malware_websocket.html to accept a "type" query parameter indicating
which environment to create the WebSocket in. Make the MalwareWebSocketBlocked
tests be parameterised on the environment type.

Due to a recent change (https://codereview.chromium.org/2960703003), these
changes need to be tested by passing --enable-features=NetworkService to
browser_tests, as opposed to the --enable-network-service argument that was
needed before.

BUG=644744

Review-Url: https://codereview.chromium.org/2971333002
Cr-Commit-Position: refs/heads/master@{#488151}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ddd2a9b99d89c93a354738181d1...
==========

[commit-bot: I haz the power, 2017-07-20 06:38:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ddd2a9b99d89c93a354738181d1...