Add a feature flag for network service and about:flags entry for it.

Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=NetworkService

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2960703003
Cr-Commit-Position: refs/heads/master@{#484295}
Committed: https://chromium.googlesource.com/chromium/src/+/a86c1ba22f89ad113a9ef80104a93c4907dba136

[jam, 2017-06-27 06:29:47]

Description was changed from

==========
Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=network-service

BUG=598073
==========

to

==========
Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=network-service

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-06-27 06:29:51]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 06:29:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 09:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 09:12:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jam, 2017-06-27 18:31:43]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 18:31:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 18:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 18:43:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-06-27 20:08:35]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 20:08:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-06-27 20:27:07]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-06-27 20:29:46]

Patchset #3 (id:40001) has been deleted

[jam, 2017-06-27 20:29:53]

Patchset #2 (id:20001) has been deleted

[jam, 2017-06-27 20:30:03]

Patchset #1 (id:1) has been deleted

[jam, 2017-06-27 21:01:56]

jam@chromium.org changed reviewers:
+ rockot@chromium.org

[jam, 2017-06-27 21:13:09]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 21:13:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-06-27 21:27:16]

lgtm

[jam, 2017-06-27 21:56:55]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-06-27 21:56:59]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:57:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 00:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 00:00:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-06-28 00:53:09]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-06-28 00:53:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 01:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 01:13:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jam, 2017-06-28 16:34:35]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 16:34:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 16:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 16:57:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2017-06-28 17:11:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 17:11:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-06-28 18:20:23]

The CQ bit was unchecked by jam@chromium.org

[Alexei Svitkine (slow), 2017-06-29 13:58:24]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-06-29 13:58:25]

https://codereview.chromium.org/2960703003/diff/90001/android_webview/rendere...
File android_webview/renderer/aw_content_renderer_client.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/android_webview/rendere...
android_webview/renderer/aw_content_renderer_client.cc:338: if
(!base::FeatureList::IsEnabled(features::kNetworkService)) {
Nit: No {}'s

https://codereview.chromium.org/2960703003/diff/90001/chrome/renderer/chrome_...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/chrome/renderer/chrome_...
chrome/renderer/chrome_content_renderer_client.cc:1612: if
(!base::FeatureList::IsEnabled(features::kNetworkService)) {
Nit: No {}'s

https://codereview.chromium.org/2960703003/diff/90001/content/browser/service...
File content/browser/service_worker/service_worker_request_handler.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/content/browser/service...
content/browser/service_worker/service_worker_request_handler.cc:134:
base::FeatureList::IsEnabled(features::kNetworkService));
NIt: Seems better to have these as separate DCHECK()'s.

https://codereview.chromium.org/2960703003/diff/90001/content/public/common/b...
File content/public/common/browser_side_navigation_policy.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/content/public/common/b...
content/public/common/browser_side_navigation_policy.cc:17:
base::FeatureList::IsEnabled(features::kNetworkService);
Shouldn't this be () && net enabled?

Otherwise, it will enable browser side navigation even if kBrowserSideNavigation
is not enabled.

(Separately, could we also remove switches::kEnableBrowserSideNavigation since
there's a feature?)

[jam, 2017-06-30 17:06:20]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 17:06:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-06-30 17:21:18]

Alexei: ptal at tools/metrics/histograms/enums.xml

https://codereview.chromium.org/2960703003/diff/90001/android_webview/rendere...
File android_webview/renderer/aw_content_renderer_client.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/android_webview/rendere...
android_webview/renderer/aw_content_renderer_client.cc:338: if
(!base::FeatureList::IsEnabled(features::kNetworkService)) {
On 2017/06/29 13:58:24, Alexei Svitkine (slow) wrote:
> Nit: No {}'s

Done.

https://codereview.chromium.org/2960703003/diff/90001/chrome/renderer/chrome_...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/chrome/renderer/chrome_...
chrome/renderer/chrome_content_renderer_client.cc:1612: if
(!base::FeatureList::IsEnabled(features::kNetworkService)) {
On 2017/06/29 13:58:24, Alexei Svitkine (slow) wrote:
> Nit: No {}'s

Done.

https://codereview.chromium.org/2960703003/diff/90001/content/browser/service...
File content/browser/service_worker/service_worker_request_handler.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/content/browser/service...
content/browser/service_worker/service_worker_request_handler.cc:134:
base::FeatureList::IsEnabled(features::kNetworkService));
On 2017/06/29 13:58:24, Alexei Svitkine (slow) wrote:
> NIt: Seems better to have these as separate DCHECK()'s.

since I'm just changing flag->feature, I'll leave it to how the original author
preferred to write it.

https://codereview.chromium.org/2960703003/diff/90001/content/public/common/b...
File content/public/common/browser_side_navigation_policy.cc (right):

https://codereview.chromium.org/2960703003/diff/90001/content/public/common/b...
content/public/common/browser_side_navigation_policy.cc:17:
base::FeatureList::IsEnabled(features::kNetworkService);
On 2017/06/29 13:58:24, Alexei Svitkine (slow) wrote:
> Shouldn't this be () && net enabled?
> 
> Otherwise, it will enable browser side navigation even if
kBrowserSideNavigation
> is not enabled.

Yep that's the intended behavior. Network Service depends on MojoLoading and
BrowserSideNavigation.

> 
> (Separately, could we also remove switches::kEnableBrowserSideNavigation since
> there's a feature?)

This is historical before the feature and is used by bots and locally be devs.
PlzNavigate will get turned on soon, so we'll take both out then.

[jam, 2017-06-30 17:21:33]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 17:21:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-06-30 17:26:25]

lgtm

[jam, 2017-06-30 17:53:30]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-07-05 14:03:00]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 14:03:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 14:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 14:47:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-07-05 17:05:21]

The CQ bit was checked by jam@chromium.org

[jam, 2017-07-05 17:05:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2960703003/#ps150001
(title: "merge")

[commit-bot: I haz the power, 2017-07-05 17:05:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 17:12:41]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1499274321802490,
"parent_rev": "e8bca89ecf5caed1890030266bff8cfc7984975b", "commit_rev":
"a86c1ba22f89ad113a9ef80104a93c4907dba136"}

[commit-bot: I haz the power, 2017-07-05 17:13:01]

Description was changed from

==========
Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=network-service

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=network-service

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2960703003
Cr-Commit-Position: refs/heads/master@{#484295}
Committed:
https://chromium.googlesource.com/chromium/src/+/a86c1ba22f89ad113a9ef80104a9...
==========

[commit-bot: I haz the power, 2017-07-05 17:13:04]

Committed patchset #6 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/a86c1ba22f89ad113a9ef80104a9...

[jam, 2017-07-05 17:16:48]

Description was changed from

==========
Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=network-service

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2960703003
Cr-Commit-Position: refs/heads/master@{#484295}
Committed:
https://chromium.googlesource.com/chromium/src/+/a86c1ba22f89ad113a9ef80104a9...
==========

to

==========
Add a feature flag for network service and about:flags entry for it.

This also changes how it's now enabled: --enable-features=NetworkService

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2960703003
Cr-Commit-Position: refs/heads/master@{#484295}
Committed:
https://chromium.googlesource.com/chromium/src/+/a86c1ba22f89ad113a9ef80104a9...
==========