SafeBrowsing test for WebSocket connection from worker

chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This test creates a safebrowsing service using test safebrowsing database
 // and a test protocol manager. It is used to test logics in safebrowsing
 // service.
 
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 
 #include <map>
 #include <set>
+#include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 1451 matching lines @@
   EXPECT_TRUE(csd_service->enabled());
 
   // Delete the Profile. SBS stops again.
   pref_service2 = nullptr;
   profile2.reset();
   EXPECT_FALSE(sb_service->enabled_by_prefs());
   WaitForIOAndCheckEnabled(sb_service, false);
   EXPECT_FALSE(csd_service->enabled());
 }
 
-IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, MalwareWebSocketBlocked) {
+// Parameterised fixture to permit running the same test for Window and Worker
+// scopes.
+class SafeBrowsingServiceWebSocketTest
+    : public ::testing::WithParamInterface<std::string>,
+      public SafeBrowsingServiceTest {};
+
+IN_PROC_BROWSER_TEST_P(SafeBrowsingServiceWebSocketTest,
+                       MalwareWebSocketBlocked) {
   // This test currently only passes when the network service is enabled.
   if (!base::FeatureList::IsEnabled(features::kNetworkService))
     return;
   GURL main_url = embedded_test_server()->GetURL(kMalwareWebSocketPage);
   // This constructs the URL with the same logic as malware_websocket.html.
   GURL resolved = main_url.Resolve("/safe_browsing/malware-ws");
   GURL::Replacements replace_scheme;
   replace_scheme.SetScheme("ws", url::Component(0, strlen("ws")));
   GURL websocket_url = resolved.ReplaceComponents(replace_scheme);
 
+  GURL::Replacements add_query;
+  std::string query = "type=" + GetParam();
+  add_query.SetQueryStr(query);
+  GURL main_url_with_query = main_url.ReplaceComponents(add_query);
+
   // Add the WebSocket url as malware.
   SBFullHashResult uws_full_hash;
   GenUrlFullHashResult(websocket_url, MALWARE, &uws_full_hash);
   SetupResponseForUrl(websocket_url, uws_full_hash);
 
   // Brute force method for waiting for the interstitial to be displayed.
   content::WindowedNotificationObserver load_stop_observer(
       content::NOTIFICATION_ALL,
       base::Bind(
           [](SafeBrowsingServiceTest* self,
              const content::NotificationSource& source,
              const content::NotificationDetails& details) {
             return self->ShowingInterstitialPage();
           },
           base::Unretained(this)));
 
   EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(websocket_url)));
-  ui_test_utils::NavigateToURL(browser(), main_url);
+  ui_test_utils::NavigateToURL(browser(), main_url_with_query);
 
   // If the interstitial fails to be displayed, the test will hang here.
   load_stop_observer.Wait();
 
   EXPECT_TRUE(ShowingInterstitialPage());
   EXPECT_TRUE(got_hit_report());
 }
 
+INSTANTIATE_TEST_CASE_P(
+    /* no prefix */,
+    SafeBrowsingServiceWebSocketTest,
+    ::testing::Values("window", "worker"));
+
 IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, UnknownWebSocketNotBlocked) {
   GURL main_url = embedded_test_server()->GetURL(kMalwareWebSocketPage);
 
   auto expected_title = base::ASCIIToUTF16("COMPLETED");
   content::TitleWatcher title_watcher(
       browser()->tab_strip_model()->GetActiveWebContents(), expected_title);
 
   // Load the parent page without marking the WebSocket as malware.
   ui_test_utils::NavigateToURL(browser(), main_url);
 
@@ skipping 709 matching lines @@
   {
     scoped_refptr<TestSBClient> client(new TestSBClient);
 
     MarkUrlForUwsUnexpired(bad_url);
 
     client->CheckBrowseUrl(bad_url);
     EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE, client->GetThreatType());
   }
 }
 
+// Parameterised fixture to permit running the same test for Window and Worker
+// scopes.
+class V4SafeBrowsingServiceWebSocketTest
+    : public ::testing::WithParamInterface<std::string>,
+      public V4SafeBrowsingServiceTest {};
+
 // This is almost identical to
-// SafeBrowsingServiceTest.MalwareWebSocketBlocked. That test will be deleted
-// when the old database backend stops being used.
-IN_PROC_BROWSER_TEST_F(V4SafeBrowsingServiceTest, MalwareWebSocketBlocked) {
+// SafeBrowsingServiceWebSocketTest.MalwareWebSocketBlocked. That test will be
+// deleted when the old database backend is removed.
+IN_PROC_BROWSER_TEST_P(V4SafeBrowsingServiceWebSocketTest,
+                       MalwareWebSocketBlocked) {
   // This test currently only passes when the network service is enabled.
   if (!base::FeatureList::IsEnabled(features::kNetworkService))
     return;
   GURL main_url = embedded_test_server()->GetURL(kMalwareWebSocketPage);
   // This constructs the URL with the same logic as malware_websocket.html.
   GURL resolved = main_url.Resolve("/safe_browsing/malware-ws");
   GURL::Replacements replace_scheme;
   replace_scheme.SetScheme("ws", url::Component(0, strlen("ws")));
   GURL websocket_url = resolved.ReplaceComponents(replace_scheme);
 
+  GURL::Replacements add_query;
+  std::string query = "type=" + GetParam();
+  add_query.SetQueryStr(query);
+  GURL main_url_with_query = main_url.ReplaceComponents(add_query);
+
   MarkUrlForMalwareUnexpired(websocket_url);
 
   // Brute force method for waiting for the interstitial to be displayed.
   content::WindowedNotificationObserver load_stop_observer(
       content::NOTIFICATION_ALL,
       base::Bind(
           [](SafeBrowsingServiceTest* self,
              const content::NotificationSource& source,
              const content::NotificationDetails& details) {
             return self->ShowingInterstitialPage();
           },
           base::Unretained(this)));
 
   EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(websocket_url)));
-  ui_test_utils::NavigateToURL(browser(), main_url);
+  ui_test_utils::NavigateToURL(browser(), main_url_with_query);
 
   // If the interstitial fails to be displayed, the test will hang here.
   load_stop_observer.Wait();
 
   EXPECT_TRUE(ShowingInterstitialPage());
   EXPECT_TRUE(got_hit_report());
   EXPECT_EQ(websocket_url, hit_report().malicious_url);
-  EXPECT_EQ(main_url, hit_report().page_url);
+  EXPECT_EQ(main_url_with_query, hit_report().page_url);
   EXPECT_TRUE(hit_report().is_subresource);
 }
 
+// TODO(ricea): Test SharedWorker and ServiceWorker scopes as well.
+INSTANTIATE_TEST_CASE_P(/* no prefix */,
+                        V4SafeBrowsingServiceWebSocketTest,
+                        ::testing::Values("window", "worker"));
+
 // Identical to SafeBrowsingServiceTest.UnknownWebSocketNotBlocked. Uses the
 // V4 database backend.
 IN_PROC_BROWSER_TEST_F(V4SafeBrowsingServiceTest, UnknownWebSocketNotBlocked) {
   GURL main_url = embedded_test_server()->GetURL(kMalwareWebSocketPage);
 
   auto expected_title = base::ASCIIToUTF16("COMPLETED");
   content::TitleWatcher title_watcher(
       browser()->tab_strip_model()->GetActiveWebContents(), expected_title);
 
   // Load the parent page without marking the WebSocket as malware.
@@ skipping 172 matching lines @@
 }
 
 INSTANTIATE_TEST_CASE_P(
     MaybeSetMetadata,
     V4SafeBrowsingServiceMetadataTest,
     testing::Values(ThreatPatternType::NONE,
                     ThreatPatternType::MALWARE_LANDING,
                     ThreatPatternType::MALWARE_DISTRIBUTION));
 
 }  // namespace safe_browsing