Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2970833002: Be explicit about namespace testing to not mix it with blink::testing (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-worker-reviews_chromium.org, cbiesinger, chromium-reviews, dglazkov+blink, dgrogan+ng_chromium.org, dshwang, eae+blinkwatch, Eric Willigers, falken+watch_chromium.org, feature-media-reviews_chromium.org, gavinp+prerender_chromium.org, glebl+reviews_chromium.org, hiroshige+script_chromium.org, horo+watch_chromium.org, jchaffraix+rendering, kenneth.christiansen, kinuko+worker_chromium.org, kinuko+watch, kochi+script_chromium.org, kouhei+script_chromium.org, lchoi+reviews_chromium.org, leviw+renderwatch, loading-reviews+parser_chromium.org, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, shans, shimazu+worker_chromium.org, sof, szager+layoutwatch_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Be explicit about namespace testing to not mix it with blink::testing There are two namespaces named testing used in Blink unit tests, one from gtest and one internal helper namespace. If both are visible then the gtest testing namespace won't be used unless prepended with ::, as is already done in large parts of the code. BUG=739121 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2970833002 Cr-Commit-Position: refs/heads/master@{#484087} Committed: https://chromium.googlesource.com/chromium/src/+/51287d5e74cd270ce91e432d072e856718b677e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -97 lines) Patch
M third_party/WebKit/Source/core/animation/TimingInputTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSLazyParsingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/threaded/MultiThreadedTestUtil.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MockScriptElementBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleMapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StaticRangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/KeyboardTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TouchEventTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/exported/WebNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElementSizesAttributeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/media/AutoplayUmaHelperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/OverflowModelTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NetworkQuietDetectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClientTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EffectiveNavigationPolicyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/PageOverlayTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 7 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/scheduler/ThrottlingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Daniel Bratell
fs, PTAL. I think that if it compiles, it's right.
3 years, 5 months ago (2017-07-04 09:57:48 UTC) #6
fs
lgtm
3 years, 5 months ago (2017-07-04 10:24:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970833002/1
3 years, 5 months ago (2017-07-04 11:30:01 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 11:36:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51287d5e74cd270ce91e432d072e...

Powered by Google App Engine
This is Rietveld 408576698