third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp - Issue 2970833002: Be explicit about namespace testing to not mix it with blink::testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp

Issue 2970833002: Be explicit about namespace testing to not mix it with blink::testing (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp b/third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp

index ee9c0339af1edd6a2f03ee6443d39f195dfdd6a2..daec4e646f0d449acce763ce7c83f25b744a265d 100644

--- a/third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp

+++ b/third_party/WebKit/Source/core/loader/DocumentLoadTimingTest.cpp

@@ -11,7 +11,7 @@

namespace blink {

-class DocumentLoadTimingTest : public testing::Test {};

+class DocumentLoadTimingTest : public ::testing::Test {};

TEST_F(DocumentLoadTimingTest, ensureValidNavigationStartAfterEmbedder) {

std::unique_ptr<DummyPageHolder> dummy_page = DummyPageHolder::Create();