Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2970163002: Enable profiling for Kabylake and Goldmont (Closed)

Created:
3 years, 5 months ago by gmx1
Modified:
3 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable profiling for Kabylake and Goldmont Add Kabylake and Goldmont models to the Intel uarch table and enable profiling for them. BUG=b:63543388 TEST=none Review-Url: https://codereview.chromium.org/2970163002 Cr-Commit-Position: refs/heads/master@{#487181} Committed: https://chromium.googlesource.com/chromium/src/+/7ddcda32b3a735186ec95f754c3d37e342cdc337

Patch Set 1 #

Patch Set 2 : Enable profiling for Kabylake and Goldmont #

Patch Set 3 : Enable profiling for Kabylake and Goldmont #

Patch Set 4 : Enable profiling for Kabylake and Goldmont #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -41 lines) Patch
M chrome/browser/metrics/perf/cpu_identity.cc View 1 1 chunk +43 lines, -38 lines 0 comments Download
M chrome/browser/metrics/perf/perf_provider_chromeos.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
gmx1
3 years, 5 months ago (2017-07-05 21:30:24 UTC) #3
chongjiang1
lgtm
3 years, 5 months ago (2017-07-05 21:38:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970163002/60001
3 years, 5 months ago (2017-07-12 00:00:30 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-12 00:00:31 UTC) #11
chongjiang1
lgtm
3 years, 5 months ago (2017-07-12 00:02:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970163002/60001
3 years, 5 months ago (2017-07-12 00:03:08 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-12 00:03:10 UTC) #17
gmx1
Alexei and Simon, can I get a review on this commit before the branch point?
3 years, 5 months ago (2017-07-17 17:25:22 UTC) #22
Simon Que
On 2017/07/17 17:25:22, gmx1 wrote: > Alexei and Simon, can I get a review on ...
3 years, 5 months ago (2017-07-17 17:45:37 UTC) #23
Alexei Svitkine (slow)
lgtm
3 years, 5 months ago (2017-07-17 17:58:57 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970163002/60001
3 years, 5 months ago (2017-07-17 18:31:02 UTC) #27
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 19:01:48 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7ddcda32b3a735186ec95f754c3d...

Powered by Google App Engine
This is Rietveld 408576698