Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chrome/browser/metrics/perf/perf_provider_chromeos.cc

Issue 2970163002: Enable profiling for Kabylake and Goldmont (Closed)
Patch Set: Enable profiling for Kabylake and Goldmont Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/perf/cpu_identity.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/perf/perf_provider_chromeos.cc
diff --git a/chrome/browser/metrics/perf/perf_provider_chromeos.cc b/chrome/browser/metrics/perf/perf_provider_chromeos.cc
index 67ba89665f7550ad6e730e608d60959b7e2f55bb..a87d1ed9b321200e3e421e5e265cf8f439efbc9b 100644
--- a/chrome/browser/metrics/perf/perf_provider_chromeos.cc
+++ b/chrome/browser/metrics/perf/perf_provider_chromeos.cc
@@ -121,7 +121,8 @@ void ExtractVersionNumbers(const std::string& version,
// Returns if a micro-architecture supports LBR callgraph profiling.
bool MicroarchitectureHasLBRCallgraph(const std::string& uarch) {
- return uarch == "Haswell" || uarch == "Broadwell" || uarch == "Skylake";
+ return uarch == "Haswell" || uarch == "Broadwell" || uarch == "Skylake" ||
+ uarch == "Kabylake";
}
// Returns if a kernel release supports LBR callgraph profiling.
@@ -195,7 +196,8 @@ const std::vector<RandomSelector::WeightAndValue> GetDefaultCommands_x86_64(
cmds.push_back(WeightAndValue(5.0, kPerfRecordCacheMissesCmd));
return cmds;
}
- if (intel_uarch == "SandyBridge" || intel_uarch == "Skylake") {
+ if (intel_uarch == "SandyBridge" || intel_uarch == "Skylake" ||
+ intel_uarch == "Kabylake") {
cmds.push_back(WeightAndValue(50.0, kPerfRecordCyclesCmd));
cmds.push_back(WeightAndValue(20.0, callgraph_cmd));
cmds.push_back(WeightAndValue(15.0, kPerfRecordLBRCmd));
@@ -204,7 +206,8 @@ const std::vector<RandomSelector::WeightAndValue> GetDefaultCommands_x86_64(
cmds.push_back(WeightAndValue(5.0, kPerfRecordCacheMissesCmd));
return cmds;
}
- if (intel_uarch == "Silvermont" || intel_uarch == "Airmont") {
+ if (intel_uarch == "Silvermont" || intel_uarch == "Airmont" ||
+ intel_uarch == "Goldmont") {
cmds.push_back(WeightAndValue(50.0, kPerfRecordCyclesCmd));
cmds.push_back(WeightAndValue(20.0, callgraph_cmd));
cmds.push_back(WeightAndValue(15.0, kPerfRecordLBRCmdAtom));
« no previous file with comments | « chrome/browser/metrics/perf/cpu_identity.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698