[DevTools] Split auto-attach part of TargetHandler into a separate class

[DevTools] Split auto-attach part of TargetHandler into a separate class

This will make multiple sessions in TargetHandler easier to handle.

BUG=590878
Review-Url: https://codereview.chromium.org/2969753002
Cr-Commit-Position: refs/heads/master@{#486558}
Committed: https://chromium.googlesource.com/chromium/src/+/9f204165f361bd4e8c3a125517603be2af437c99

[dgozman, 2017-06-30 23:45:28]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-06-30 23:45:40]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-06-30 23:45:40]

Could you please take a look?

[commit-bot: I haz the power, 2017-06-30 23:45:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-06-30 23:46:14]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 23:46:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 01:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 01:03:06]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-07-07 00:53:11]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-07-07 00:53:12]

Take a look please?

[caseq, 2017-07-07 17:46:33]

lgtm

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/target_auto_attacher.h (right):

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/target_auto_attacher.h:21: using
AttachCallback = base::Callback<bool(DevToolsAgentHost*, bool)>;
nit: consider introducing client interface instead.

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:646:
target->DidFinishNavigation();
Not sure if it's fair to rename this to DidFinishNavigation, considering it's
only called conditionally.

[dgozman, 2017-07-13 21:46:22]

Thank you for review!

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/target_auto_attacher.h (right):

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/target_auto_attacher.h:21: using
AttachCallback = base::Callback<bool(DevToolsAgentHost*, bool)>;
On 2017/07/07 17:46:33, caseq wrote:
> nit: consider introducing client interface instead.

Acknowledged.

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2969753002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:646:
target->DidFinishNavigation();
On 2017/07/07 17:46:33, caseq wrote:
> Not sure if it's fair to rename this to DidFinishNavigation, considering it's
> only called conditionally.

Renamed to DidCommitNavigation.

[dgozman, 2017-07-13 21:46:29]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-07-13 21:46:30]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2969753002/#ps40001
(title: "rebased, addressed comment")

[commit-bot: I haz the power, 2017-07-13 21:47:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 00:55:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499982389949110,
"parent_rev": "19cbc1d36c775115307c12cc99a67770ee108eff", "commit_rev":
"d88841b90bd857662216c682e249bb1eeecf46a9"}

[commit-bot: I haz the power, 2017-07-14 00:55:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499982389949110,
"parent_rev": "41a9b91b34b2a4cd32ee77ef6afca9ed275fb2d1", "commit_rev":
"9f204165f361bd4e8c3a125517603be2af437c99"}

[commit-bot: I haz the power, 2017-07-14 00:56:06]

Description was changed from

==========
[DevTools] Split auto-attach part of TargetHandler into a separate class

This will make multiple sessions in TargetHandler easier to handle.

BUG=590878
==========

to

==========
[DevTools] Split auto-attach part of TargetHandler into a separate class

This will make multiple sessions in TargetHandler easier to handle.

BUG=590878

Review-Url: https://codereview.chromium.org/2969753002
Cr-Commit-Position: refs/heads/master@{#486558}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f204165f361bd4e8c3a12551760...
==========

[commit-bot: I haz the power, 2017-07-14 00:56:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f204165f361bd4e8c3a12551760...