Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: content/browser/devtools/protocol/target_handler.h

Issue 2969753002: [DevTools] Split auto-attach part of TargetHandler into a separate class (Closed)
Patch Set: rebased, addressed comment Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TARGET_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TARGET_HANDLER_H_
6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TARGET_HANDLER_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TARGET_HANDLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 10
11 #include "content/browser/devtools/protocol/devtools_domain_handler.h" 11 #include "content/browser/devtools/protocol/devtools_domain_handler.h"
12 #include "content/browser/devtools/protocol/target.h" 12 #include "content/browser/devtools/protocol/target.h"
13 #include "content/browser/devtools/service_worker_devtools_manager.h" 13 #include "content/browser/devtools/protocol/target_auto_attacher.h"
14 #include "content/public/browser/devtools_agent_host_client.h" 14 #include "content/public/browser/devtools_agent_host_client.h"
15 #include "content/public/browser/devtools_agent_host_observer.h" 15 #include "content/public/browser/devtools_agent_host_observer.h"
16 16
17 namespace content { 17 namespace content {
18 18
19 class DevToolsAgentHostImpl; 19 class DevToolsAgentHostImpl;
20 class RenderFrameHostImpl; 20 class RenderFrameHostImpl;
21 21
22 namespace protocol { 22 namespace protocol {
23 23
24 class TargetHandler : public DevToolsDomainHandler, 24 class TargetHandler : public DevToolsDomainHandler,
25 public Target::Backend, 25 public Target::Backend,
26 public DevToolsAgentHostClient, 26 public DevToolsAgentHostClient,
27 public ServiceWorkerDevToolsManager::Observer,
28 public DevToolsAgentHostObserver { 27 public DevToolsAgentHostObserver {
29 public: 28 public:
30 TargetHandler(); 29 TargetHandler();
31 ~TargetHandler() override; 30 ~TargetHandler() override;
32 31
33 static std::vector<TargetHandler*> ForAgentHost(DevToolsAgentHostImpl* host); 32 static std::vector<TargetHandler*> ForAgentHost(DevToolsAgentHostImpl* host);
34 33
35 void Wire(UberDispatcher* dispatcher) override; 34 void Wire(UberDispatcher* dispatcher) override;
36 void SetRenderFrameHost(RenderFrameHostImpl* host) override; 35 void SetRenderFrameHost(RenderFrameHostImpl* host) override;
37 Response Disable() override; 36 Response Disable() override;
38 37
39 void UpdateServiceWorkers(); 38 void DidCommitNavigation();
40 void UpdateFrames(); 39 void RenderFrameHostChanged();
41 40
42 // Domain implementation. 41 // Domain implementation.
43 Response SetDiscoverTargets(bool discover) override; 42 Response SetDiscoverTargets(bool discover) override;
44 Response SetAutoAttach(bool auto_attach, 43 Response SetAutoAttach(bool auto_attach,
45 bool wait_for_debugger_on_start) override; 44 bool wait_for_debugger_on_start) override;
46 Response SetAttachToFrames(bool value) override; 45 Response SetAttachToFrames(bool value) override;
47 Response SetRemoteLocations( 46 Response SetRemoteLocations(
48 std::unique_ptr<protocol::Array<Target::RemoteLocation>>) override; 47 std::unique_ptr<protocol::Array<Target::RemoteLocation>>) override;
49 Response AttachToTarget(const std::string& target_id, 48 Response AttachToTarget(const std::string& target_id,
50 bool* out_success) override; 49 bool* out_success) override;
(...skipping 12 matching lines...) Expand all
63 Response CreateTarget(const std::string& url, 62 Response CreateTarget(const std::string& url,
64 Maybe<int> width, 63 Maybe<int> width,
65 Maybe<int> height, 64 Maybe<int> height,
66 Maybe<std::string> context_id, 65 Maybe<std::string> context_id,
67 std::string* out_target_id) override; 66 std::string* out_target_id) override;
68 Response GetTargets( 67 Response GetTargets(
69 std::unique_ptr<protocol::Array<Target::TargetInfo>>* target_infos) 68 std::unique_ptr<protocol::Array<Target::TargetInfo>>* target_infos)
70 override; 69 override;
71 70
72 private: 71 private:
73 using HostsMap = std::map<std::string, scoped_refptr<DevToolsAgentHost>>;
74 using RawHostsMap = std::map<std::string, DevToolsAgentHost*>; 72 using RawHostsMap = std::map<std::string, DevToolsAgentHost*>;
75 73
76 void UpdateServiceWorkers(bool waiting_for_debugger);
77 void ReattachTargetsOfType(const HostsMap& new_hosts,
78 const std::string& type,
79 bool waiting_for_debugger);
80 void TargetCreatedInternal(DevToolsAgentHost* host); 74 void TargetCreatedInternal(DevToolsAgentHost* host);
81 void TargetInfoChangedInternal(DevToolsAgentHost* host); 75 void TargetInfoChangedInternal(DevToolsAgentHost* host);
82 void TargetDestroyedInternal(DevToolsAgentHost* host); 76 void TargetDestroyedInternal(DevToolsAgentHost* host);
83 bool AttachToTargetInternal(DevToolsAgentHost* host, 77 bool AttachToTargetInternal(DevToolsAgentHost* host,
84 bool waiting_for_debugger); 78 bool waiting_for_debugger);
85 void DetachFromTargetInternal(DevToolsAgentHost* host); 79 void DetachFromTargetInternal(DevToolsAgentHost* host);
86 80
87 // ServiceWorkerDevToolsManager::Observer implementation.
88 void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) override;
89 void WorkerReadyForInspection(ServiceWorkerDevToolsAgentHost* host) override;
90 void WorkerVersionInstalled(ServiceWorkerDevToolsAgentHost* host) override;
91 void WorkerVersionDoomed(ServiceWorkerDevToolsAgentHost* host) override;
92 void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) override;
93
94 // DevToolsAgentHostObserver implementation. 81 // DevToolsAgentHostObserver implementation.
95 bool ShouldForceDevToolsAgentHostCreation() override; 82 bool ShouldForceDevToolsAgentHostCreation() override;
96 void DevToolsAgentHostCreated(DevToolsAgentHost* agent_host) override; 83 void DevToolsAgentHostCreated(DevToolsAgentHost* agent_host) override;
97 void DevToolsAgentHostDestroyed(DevToolsAgentHost* agent_host) override; 84 void DevToolsAgentHostDestroyed(DevToolsAgentHost* agent_host) override;
98 void DevToolsAgentHostAttached(DevToolsAgentHost* agent_host) override; 85 void DevToolsAgentHostAttached(DevToolsAgentHost* agent_host) override;
99 void DevToolsAgentHostDetached(DevToolsAgentHost* agent_host) override; 86 void DevToolsAgentHostDetached(DevToolsAgentHost* agent_host) override;
100 87
101 // DevToolsAgentHostClient implementation. 88 // DevToolsAgentHostClient implementation.
102 void DispatchProtocolMessage(DevToolsAgentHost* agent_host, 89 void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
103 const std::string& message) override; 90 const std::string& message) override;
104 void AgentHostClosed(DevToolsAgentHost* agent_host, 91 void AgentHostClosed(DevToolsAgentHost* agent_host,
105 bool replaced_with_another_client) override; 92 bool replaced_with_another_client) override;
106 93
107 std::unique_ptr<Target::Frontend> frontend_; 94 std::unique_ptr<Target::Frontend> frontend_;
95 TargetAutoAttacher auto_attacher_;
108 bool discover_; 96 bool discover_;
109 bool auto_attach_; 97 std::map<std::string, scoped_refptr<DevToolsAgentHost>> attached_hosts_;
110 bool wait_for_debugger_on_start_;
111 bool attach_to_frames_;
112 RenderFrameHostImpl* render_frame_host_;
113 HostsMap attached_hosts_;
114 std::set<GURL> frame_urls_;
115 RawHostsMap reported_hosts_; 98 RawHostsMap reported_hosts_;
116 99
117 DISALLOW_COPY_AND_ASSIGN(TargetHandler); 100 DISALLOW_COPY_AND_ASSIGN(TargetHandler);
118 }; 101 };
119 102
120 } // namespace protocol 103 } // namespace protocol
121 } // namespace content 104 } // namespace content
122 105
123 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TARGET_HANDLER_H_ 106 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TARGET_HANDLER_H_
OLDNEW
« no previous file with comments | « content/browser/devtools/protocol/target_auto_attacher.cc ('k') | content/browser/devtools/protocol/target_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698