[DevTools] Split auto-attach part of TargetHandler into a separate class

content/browser/devtools/render_frame_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_frame_devtools_agent_host.h"
 
 #include <tuple>
 #include <utility>
 
 #include "base/guid.h"
@@ skipping 625 matching lines @@
   if (!IsBrowserSideNavigationEnabled()) {
     // CommitPending may destruct |this|.
     scoped_refptr<RenderFrameDevToolsAgentHost> protect(this);
     if (navigation_handle->HasCommitted() &&
         !navigation_handle->IsErrorPage()) {
       if (pending_ &&
           pending_->host() == navigation_handle->GetRenderFrameHost()) {
         CommitPending();
       }
       for (auto* target : protocol::TargetHandler::ForAgentHost(this))
-        target->UpdateServiceWorkers();
+        target->DidFinishNavigation();

[caseq, 2017/07/07 17:46:33]

Not sure if it's fair to rename this to DidFinishNavigation, considering it's
only called conditionally.

[dgozman, 2017/07/13 21:46:22]

Renamed to DidCommitNavigation.

     } else if (pending_ && pending_->host()->GetFrameTreeNodeId() ==
                                navigation_handle->GetFrameTreeNodeId()) {
       DiscardPending();
     }
     DCHECK(CheckConsistency());
     return;
   }
 
   NavigationHandleImpl* handle =
       static_cast<NavigationHandleImpl*>(navigation_handle);
@@ skipping 17 matching lines @@
               message.method, message.message));
         }
         session->waiting_messages()[message.call_id] = {message.method,
                                                         message.message};
       }
     }
     suspended_messages_by_session_id_.clear();
   }
   if (handle->HasCommitted()) {
     for (auto* target : protocol::TargetHandler::ForAgentHost(this))
-      target->UpdateServiceWorkers();
+      target->DidFinishNavigation();
   }
 }
 
 void RenderFrameDevToolsAgentHost::UpdateFrameHost(
     RenderFrameHostImpl* frame_host) {
   if (frame_host == frame_host_) {
     if (frame_host && !render_frame_alive_) {
       render_frame_alive_ = true;
       MaybeReattachToRenderFrame();
     }
@@ skipping 113 matching lines @@
   if (handle->frame_tree_node() != frame_tree_node_)
     return;
   navigation_handles_.insert(handle);
   DCHECK(CheckConsistency());
 }
 
 void RenderFrameDevToolsAgentHost::RenderFrameHostChanged(
     RenderFrameHost* old_host,
     RenderFrameHost* new_host) {
   for (auto* target : protocol::TargetHandler::ForAgentHost(this))
-    target->UpdateFrames();
+    target->RenderFrameHostChanged();
 
   if (IsBrowserSideNavigationEnabled()) {
     if (old_host != frame_host_)
       return;
 
     // UpdateFrameHost may destruct |this|.
     scoped_refptr<RenderFrameDevToolsAgentHost> protect(this);
     UpdateFrameHost(nullptr);
     DCHECK(CheckConsistency());
     return;
@@ skipping 478 matching lines @@
 bool RenderFrameDevToolsAgentHost::IsChildFrame() {
   return frame_tree_node_ && frame_tree_node_->parent();
 }
 
 DevToolsSession* RenderFrameDevToolsAgentHost::SingleSession() {
   DCHECK(!IsBrowserSideNavigationEnabled());
   return sessions().empty() ? nullptr : *sessions().begin();
 }
 
 }  // namespace content