appengine/swarming/swarming_bot/bot_code/remote_client.py - Issue 2969513002: Add a default Isolate gRPC proxy in config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/swarming_bot/bot_code/remote_client.py

Issue 2969513002: Add a default Isolate gRPC proxy in config (Closed)

Patch Set: Fix problem in tests Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/swarming/swarming_bot/bot_code/remote_client.py

diff --git a/appengine/swarming/swarming_bot/bot_code/remote_client.py b/appengine/swarming/swarming_bot/bot_code/remote_client.py

index 2d494ffe2be087bd25c8b072f72caa9ca1748a27..579e537a69583adca224ada7aff4d44ec62047d5 100644

--- a/appengine/swarming/swarming_bot/bot_code/remote_client.py

+++ b/appengine/swarming/swarming_bot/bot_code/remote_client.py

@@ -41,10 +41,10 @@ AUTH_HEADERS_EXPIRATION_SEC = 4*60+30

NET_CONNECTION_TIMEOUT_SEC = 3*60

-def createRemoteClient(server, auth, useGrpc):

- if useGrpc:

+def createRemoteClient(server, auth, grpc_proxy):

+ if grpc_proxy:

import remote_client_grpc

- return remote_client_grpc.RemoteClientGrpc(server)

+ return remote_client_grpc.RemoteClientGrpc(grpc_proxy)

return RemoteClientNative(server, auth)