Move IA2 State handling to AXPlatformNodeWin.

Move IA2 State handling to AXPlatformNodeWin.

This CL moves all ia2_state handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward get_states() to
AXPlatformNodeWin as well.

BUG=703369
Review-Url: https://codereview.chromium.org/2968833002
Cr-Commit-Position: refs/heads/master@{#485862}
Committed: https://chromium.googlesource.com/chromium/src/+/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce

[dougt, 2017-07-01 06:09:26]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 06:09:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-07-01 08:07:18]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dougt, 2017-07-01 08:07:19]

dmazzoni, ptal

[dmazzoni, 2017-07-06 22:54:57]

lgtm

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.cc (right):

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1601: const AXNodeData& data =
GetData();
Not sure how significant this is, but we're calling
GetData more times now. Previously we'd call it
fewer times and compute a lot from it, now we
call it inside each function.

For web, GetData is fast, but for Views we
recompute it each time.

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.h (right):

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.h:277: int32_t MSAA_IA2State();
Nit: I'd just call this IA2State, as MSAA usually
just refers to IAccessible. Not sure if that's
more confusing to outsiders, though, but
even though IAccessible2 extends IAccessible, it's
not from MS.

[dougt, 2017-07-11 05:31:42]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 05:32:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-07-11 20:59:27]

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.cc (right):

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1601: const AXNodeData& data =
GetData();
On 2017/07/06 22:54:57, dmazzoni_ooo_until_july_17 wrote:
> Not sure how significant this is, but we're calling
> GetData more times now. Previously we'd call it
> fewer times and compute a lot from it, now we
> call it inside each function.
> 
> For web, GetData is fast, but for Views we
> recompute it each time.
> 

Acknowledged.  Do you think we should measure the cost of calling GetData() and
collect telemetry in a follow up?

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.h (right):

https://codereview.chromium.org/2968833002/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.h:277: int32_t MSAA_IA2State();
On 2017/07/06 22:54:57, dmazzoni_ooo_until_july_17 wrote:
> Nit: I'd just call this IA2State, as MSAA usually
> just refers to IAccessible. Not sure if that's
> more confusing to outsiders, though, but
> even though IAccessible2 extends IAccessible, it's
> not from MS.

Done.

[dougt, 2017-07-11 20:59:37]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-07-11 20:59:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2968833002/#ps80001
(title: "Add a TODO() as suggested by dmazzoni")

[commit-bot: I haz the power, 2017-07-11 21:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 21:00:03]

This CL has an open dependency (Issue 2967493005 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[dougt, 2017-07-11 22:39:03]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-07-11 22:39:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 02:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 02:47:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dougt, 2017-07-12 04:00:42]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-07-12 04:00:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 04:32:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499832042572400,
"parent_rev": "2278ffaff83a13e52290b5464f6a0ada75520506", "commit_rev":
"c836dc519c8e2043e006e5fcb62f3cf48d7e00ce"}

[commit-bot: I haz the power, 2017-07-12 04:32:23]

Description was changed from

==========
Move IA2 State handling to AXPlatformNodeWin.

This CL moves all ia2_state handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward get_states() to
AXPlatformNodeWin as well.

BUG=703369
==========

to

==========
Move IA2 State handling to AXPlatformNodeWin.

This CL moves all ia2_state handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward get_states() to
AXPlatformNodeWin as well.

BUG=703369

Review-Url: https://codereview.chromium.org/2968833002
Cr-Commit-Position: refs/heads/master@{#485862}
Committed:
https://chromium.googlesource.com/chromium/src/+/c836dc519c8e2043e006e5fcb62f...
==========

[commit-bot: I haz the power, 2017-07-12 04:32:24]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c836dc519c8e2043e006e5fcb62f...