Use MSAA_Role directly from BrowserAccessibility.

Use MSAA_Role directly from BrowserAccessibility.

During the move of get_accRole(), I left the ia_role initialization in
BrowserAccessibilityComWin::InitRoleAndState(). This CL removes this
duplication and prevents any further drift between the files.

BUG=703369
Review-Url: https://codereview.chromium.org/2967493005
Cr-Commit-Position: refs/heads/master@{#485704}
Committed: https://chromium.googlesource.com/chromium/src/+/731db9d2f7dca2fe98df656ed9b139e494409793

[dougt, 2017-07-01 05:13:09]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 05:13:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 06:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 06:05:41]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-07-01 08:04:59]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dougt, 2017-07-01 08:05:00]

dmazzoni, ptal

[dmazzoni, 2017-07-06 22:48:28]

lgtm

https://codereview.chromium.org/2967493005/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.cc (right):

https://codereview.chromium.org/2967493005/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1939: // If parent was a
rowgroup, we need to look at the grandparent
nit: move comment above and get rid of {}

https://codereview.chromium.org/2967493005/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1943: if (!container) {
nit: remove {}

[dougt, 2017-07-11 04:50:43]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 04:50:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 07:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 07:03:22]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dougt, 2017-07-11 17:36:34]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 17:36:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-07-11 17:37:43]

dougt@chromium.org changed reviewers:
+ nektar@chromium.org

[dougt, 2017-07-11 17:37:44]

nektar, ptal at the test changes. I have updated them based on our conversation.

https://codereview.chromium.org/2967493005/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.cc (right):

https://codereview.chromium.org/2967493005/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1939: // If parent was a
rowgroup, we need to look at the grandparent
On 2017/07/06 22:48:28, dmazzoni_ooo_until_july_17 wrote:
> nit: move comment above and get rid of {}

Done.

https://codereview.chromium.org/2967493005/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1943: if (!container) {
On 2017/07/06 22:48:28, dmazzoni_ooo_until_july_17 wrote:
> nit: remove {}

Done.

[commit-bot: I haz the power, 2017-07-11 18:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 18:42:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-07-11 18:51:17]

lgtm

[dougt, 2017-07-11 18:53:32]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-07-11 18:53:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2967493005/#ps80001
(title: "Change tests to match internal ax tree.")

[commit-bot: I haz the power, 2017-07-11 18:54:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 22:32:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499799212412520,
"parent_rev": "fc666dc7bc9d5141a6457ee08b0004c705463140", "commit_rev":
"03824be603972663e8ce1b03adca874f43ff9dda"}

[commit-bot: I haz the power, 2017-07-11 22:32:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499799212412520,
"parent_rev": "7d09ec39745ab090432196ced2e2bd98678e122a", "commit_rev":
"1e2451dd908d2f73a940e250cd1acf4170fb492a"}

[commit-bot: I haz the power, 2017-07-11 22:33:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499799212412520,
"parent_rev": "d713a5d20ca36dac598e4e5a841c05f84bfd5d9a", "commit_rev":
"731db9d2f7dca2fe98df656ed9b139e494409793"}

[commit-bot: I haz the power, 2017-07-11 22:33:21]

Description was changed from

==========
Use MSAA_Role directly from BrowserAccessibility.

During the move of get_accRole(), I left the ia_role initialization in
BrowserAccessibilityComWin::InitRoleAndState(). This CL removes this
duplication and prevents any further drift between the files.

BUG=703369
==========

to

==========
Use MSAA_Role directly from BrowserAccessibility.

During the move of get_accRole(), I left the ia_role initialization in
BrowserAccessibilityComWin::InitRoleAndState(). This CL removes this
duplication and prevents any further drift between the files.

BUG=703369

Review-Url: https://codereview.chromium.org/2967493005
Cr-Commit-Position: refs/heads/master@{#485704}
Committed:
https://chromium.googlesource.com/chromium/src/+/731db9d2f7dca2fe98df656ed9b1...
==========

[commit-bot: I haz the power, 2017-07-11 22:33:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/731db9d2f7dca2fe98df656ed9b1...