Move IA2 Role handling to AXPlatformNodeWin.

Move IA2 Role handling to AXPlatformNodeWin.

This CL moves all ia2_role handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward IAccessible2::role() to
AXPlatformNodeWin as well.

BUG=703369
Review-Url: https://codereview.chromium.org/2965873002
Cr-Commit-Position: refs/heads/master@{#485872}
Committed: https://chromium.googlesource.com/chromium/src/+/7e6b541f1c1347d07ed12751cd8d35c67dc8a102

[dougt, 2017-07-01 06:46:42]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 06:46:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 07:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 07:45:26]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-07-01 08:06:02]

dmazzoni, ptal

[dougt, 2017-07-01 08:07:39]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-07-06 22:58:05]

lgtm

https://codereview.chromium.org/2965873002/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_com_win.cc (left):

https://codereview.chromium.org/2965873002/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_com_win.cc:3551:
InitRoleAndState();
Nice!!!

https://codereview.chromium.org/2965873002/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_com_win.cc:3739: if
(owner()->IsWebAreaForPresentationalIframe()) {
Hmmm, in one of the previous changes this was partially
migrated. It might be nice to have that change add a TODO
here and have this change remove it, just so all of the
changes really stand on their own

https://codereview.chromium.org/2965873002/diff/20001/ui/accessibility/platfo...
File ui/accessibility/platform/ax_platform_node_win.cc (right):

https://codereview.chromium.org/2965873002/diff/20001/ui/accessibility/platfo...
ui/accessibility/platform/ax_platform_node_win.cc:1659: int32_t
AXPlatformNodeWin::MSAA_IA2Role() {
Same, I'd drop MSAA_

I'd also add a comment here that we only return a role
here if the MSAA role doesn't suffice. That's more
easy to see from reading the previous code but should
be explained more clearly here.

[dougt, 2017-07-11 05:57:25]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 05:57:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-07-12 04:57:21]

On 2017/07/06 22:58:05, dmazzoni_ooo_until_july_17 wrote:
> lgtm
> 
>
https://codereview.chromium.org/2965873002/diff/20001/content/browser/accessi...
> File content/browser/accessibility/browser_accessibility_com_win.cc (left):
> 
>
https://codereview.chromium.org/2965873002/diff/20001/content/browser/accessi...
> content/browser/accessibility/browser_accessibility_com_win.cc:3551:
> InitRoleAndState();
> Nice!!!
> 
>
https://codereview.chromium.org/2965873002/diff/20001/content/browser/accessi...
> content/browser/accessibility/browser_accessibility_com_win.cc:3739: if
> (owner()->IsWebAreaForPresentationalIframe()) {
> Hmmm, in one of the previous changes this was partially
> migrated. It might be nice to have that change add a TODO
> here and have this change remove it, just so all of the
> changes really stand on their own
> 
>
https://codereview.chromium.org/2965873002/diff/20001/ui/accessibility/platfo...
> File ui/accessibility/platform/ax_platform_node_win.cc (right):
> 
>
https://codereview.chromium.org/2965873002/diff/20001/ui/accessibility/platfo...
> ui/accessibility/platform/ax_platform_node_win.cc:1659: int32_t
> AXPlatformNodeWin::MSAA_IA2Role() {
> Same, I'd drop MSAA_

Done!

> 
> I'd also add a comment here that we only return a role
> here if the MSAA role doesn't suffice. That's more
> easy to see from reading the previous code but should
> be explained more clearly here.

Did this is the other CL.

[dougt, 2017-07-12 04:57:41]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-07-12 04:57:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2965873002/#ps100001
(title: "Comment IA2Role")

[commit-bot: I haz the power, 2017-07-12 04:57:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 06:03:30]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499835461919280,
"parent_rev": "7fe59e8349a6e6e6a2511277108acdbeeaa83b6f", "commit_rev":
"7e6b541f1c1347d07ed12751cd8d35c67dc8a102"}

[commit-bot: I haz the power, 2017-07-12 06:03:48]

Description was changed from

==========
Move IA2 Role handling to AXPlatformNodeWin.

This CL moves all ia2_role handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward IAccessible2::role() to
AXPlatformNodeWin as well.

BUG=703369
==========

to

==========
Move IA2 Role handling to AXPlatformNodeWin.

This CL moves all ia2_role handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward IAccessible2::role() to
AXPlatformNodeWin as well.

BUG=703369

Review-Url: https://codereview.chromium.org/2965873002
Cr-Commit-Position: refs/heads/master@{#485872}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e6b541f1c1347d07ed12751cd8d...
==========

[commit-bot: I haz the power, 2017-07-12 06:03:49]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7e6b541f1c1347d07ed12751cd8d...