Issue 2968553002: Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2968553002: Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable… (Closed)

Created:
3 years, 5 months ago by wangyix1

Modified:
3 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates, gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization. Merge internal change: 160312965 R=rch@chromium.org

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -70 lines)			Patch
M	net/quic/core/congestion_control/cubic_bytes_test.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	net/quic/core/congestion_control/cubic_test.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	net/quic/core/congestion_control/send_algorithm_test.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	net/quic/core/congestion_control/tcp_cubic_sender_packets.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 2959373002 Patch 20001

Dependent Patchsets:

Issue 2961313004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages