Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Side by Side Diff: net/quic/core/congestion_control/cubic_test.cc

Issue 2968553002: Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable… (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/congestion_control/cubic.h" 5 #include "net/quic/core/congestion_control/cubic.h"
6 6
7 #include <cstdint> 7 #include <cstdint>
8 8
9 #include "net/quic/platform/api/quic_flags.h" 9 #include "net/quic/platform/api/quic_flags.h"
10 #include "net/quic/platform/api/quic_str_cat.h" 10 #include "net/quic/platform/api/quic_str_cat.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 "beta_last_max_", params.param.fix_beta_last_max, "_", 51 "beta_last_max_", params.param.fix_beta_last_max, "_",
52 "allow_per_ack_updates_", 52 "allow_per_ack_updates_",
53 params.param.allow_per_ack_updates); 53 params.param.allow_per_ack_updates);
54 } 54 }
55 55
56 std::vector<TestParams> GetTestParams() { 56 std::vector<TestParams> GetTestParams() {
57 std::vector<TestParams> params; 57 std::vector<TestParams> params;
58 for (bool fix_convex_mode : {true, false}) { 58 for (bool fix_convex_mode : {true, false}) {
59 for (bool fix_beta_last_max : {true, false}) { 59 for (bool fix_beta_last_max : {true, false}) {
60 for (bool allow_per_ack_updates : {true, false}) { 60 for (bool allow_per_ack_updates : {true, false}) {
61 if (!FLAGS_quic_reloadable_flag_quic_fix_cubic_convex_mode &&
62 fix_convex_mode) {
63 continue;
64 }
65 if (!FLAGS_quic_reloadable_flag_quic_fix_beta_last_max &&
66 fix_beta_last_max) {
67 continue;
68 }
69 if (!FLAGS_quic_reloadable_flag_quic_enable_cubic_per_ack_updates &&
70 allow_per_ack_updates) {
71 continue;
72 }
73 TestParams param(fix_convex_mode, fix_beta_last_max, 61 TestParams param(fix_convex_mode, fix_beta_last_max,
74 allow_per_ack_updates); 62 allow_per_ack_updates);
75 params.push_back(param); 63 params.push_back(param);
76 } 64 }
77 } 65 }
78 } 66 }
79 return params; 67 return params;
80 } 68 }
81 69
82 } // namespace 70 } // namespace
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 clock_.AdvanceTime(hundred_ms_); 358 clock_.AdvanceTime(hundred_ms_);
371 current_cwnd = cubic_.CongestionWindowAfterAck(current_cwnd, rtt_min, 359 current_cwnd = cubic_.CongestionWindowAfterAck(current_cwnd, rtt_min,
372 clock_.ApproximateNow()); 360 clock_.ApproximateNow());
373 } 361 }
374 expected_cwnd = 399; 362 expected_cwnd = 399;
375 EXPECT_EQ(expected_cwnd, current_cwnd); 363 EXPECT_EQ(expected_cwnd, current_cwnd);
376 } 364 }
377 365
378 } // namespace test 366 } // namespace test
379 } // namespace net 367 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/congestion_control/cubic_bytes_test.cc ('k') | net/quic/core/congestion_control/send_algorithm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698