Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: net/tools/quic/end_to_end_test.cc

Issue 2968553002: Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable… (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/quic_flags_list.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <sys/epoll.h> 6 #include <sys/epoll.h>
7 7
8 #include <cstdint> 8 #include <cstdint>
9 #include <list> 9 #include <list>
10 #include <memory> 10 #include <memory>
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 } 377 }
378 378
379 bool Initialize() { 379 bool Initialize() {
380 QuicTagVector copt; 380 QuicTagVector copt;
381 server_config_.SetConnectionOptionsToSend(copt); 381 server_config_.SetConnectionOptionsToSend(copt);
382 copt = client_extra_copts_; 382 copt = client_extra_copts_;
383 383
384 // TODO(nimia): Consider setting the congestion control algorithm for the 384 // TODO(nimia): Consider setting the congestion control algorithm for the
385 // client as well according to the test parameter. 385 // client as well according to the test parameter.
386 copt.push_back(GetParam().congestion_control_tag); 386 copt.push_back(GetParam().congestion_control_tag);
387 if (GetParam().congestion_control_tag == kQBIC && 387 if (GetParam().congestion_control_tag == kQBIC) {
388 FLAGS_quic_reloadable_flag_quic_fix_cubic_convex_mode) {
389 copt.push_back(kCCVX); 388 copt.push_back(kCCVX);
390 } 389 }
391 if (GetParam().congestion_control_tag == kQBIC && 390 if (GetParam().congestion_control_tag == kQBIC) {
392 FLAGS_quic_reloadable_flag_quic_fix_cubic_bytes_quantization) {
393 copt.push_back(kCBQT); 391 copt.push_back(kCBQT);
394 } 392 }
395 if (GetParam().congestion_control_tag == kQBIC && 393 if (GetParam().congestion_control_tag == kQBIC) {
396 FLAGS_quic_reloadable_flag_quic_enable_cubic_per_ack_updates) {
397 copt.push_back(kCPAU); 394 copt.push_back(kCPAU);
398 } 395 }
399 if (GetParam().congestion_control_tag == kTPCC && 396 if (GetParam().congestion_control_tag == kTPCC &&
400 FLAGS_quic_reloadable_flag_quic_enable_pcc) { 397 FLAGS_quic_reloadable_flag_quic_enable_pcc) {
401 copt.push_back(kTPCC); 398 copt.push_back(kTPCC);
402 } 399 }
403 400
404 if (support_server_push_) { 401 if (support_server_push_) {
405 copt.push_back(kSPSH); 402 copt.push_back(kSPSH);
406 } 403 }
(...skipping 2672 matching lines...) Expand 10 before | Expand all | Expand 10 after
3079 client_->WaitForResponse(); 3076 client_->WaitForResponse();
3080 EXPECT_EQ(kBarResponseBody, client_->response_body()); 3077 EXPECT_EQ(kBarResponseBody, client_->response_body());
3081 QuicConnectionStats client_stats = 3078 QuicConnectionStats client_stats =
3082 client_->client()->session()->connection()->GetStats(); 3079 client_->client()->session()->connection()->GetStats();
3083 EXPECT_EQ(0u, client_stats.packets_lost); 3080 EXPECT_EQ(0u, client_stats.packets_lost);
3084 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos()); 3081 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos());
3085 } 3082 }
3086 } // namespace 3083 } // namespace
3087 } // namespace test 3084 } // namespace test
3088 } // namespace net 3085 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/quic_flags_list.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698