Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: net/quic/core/quic_flags_list.h

Issue 2968553002: Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable… (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file intentionally does not have header guards, it's included 5 // This file intentionally does not have header guards, it's included
6 // inside a macro to generate values. 6 // inside a macro to generate values.
7 7
8 // This file contains the list of QUIC protocol flags. 8 // This file contains the list of QUIC protocol flags.
9 9
10 // Time period for which a given connection_id should live in the time-wait 10 // Time period for which a given connection_id should live in the time-wait
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // public flag. 79 // public flag.
80 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_remove_v33_hacks2, false) 80 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_remove_v33_hacks2, false)
81 81
82 // Enable QUIC force HOL blocking experiment. 82 // Enable QUIC force HOL blocking experiment.
83 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_force_hol_blocking, true) 83 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_force_hol_blocking, true)
84 84
85 // If true, allows packets to be buffered in anticipation of a future CHLO, and 85 // If true, allows packets to be buffered in anticipation of a future CHLO, and
86 // allow CHLO packets to be buffered until next iteration of the event loop. 86 // allow CHLO packets to be buffered until next iteration of the event loop.
87 QUIC_FLAG(bool, FLAGS_quic_allow_chlo_buffering, true) 87 QUIC_FLAG(bool, FLAGS_quic_allow_chlo_buffering, true)
88 88
89 // If true, fix some casts that were causing off-by-one errors in QUIC's cubic
90 // "convex" increases.
91 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_cubic_convex_mode, true)
92
93 // If true, GFE sends SETTINGS_MAX_HEADER_LIST_SIZE to the client at the 89 // If true, GFE sends SETTINGS_MAX_HEADER_LIST_SIZE to the client at the
94 // beginning of a connection. 90 // beginning of a connection.
95 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_send_max_header_list_size, true) 91 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_send_max_header_list_size, true)
96 92
97 // If true, fix quantization of CubicBytes while performing convex increases.
98 QUIC_FLAG(bool,
99 FLAGS_quic_reloadable_flag_quic_fix_cubic_bytes_quantization,
100 true)
101
102 // If true, fix Cubic\'s use of kBetaLastMax for n-connection emulation.
103 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, true)
104
105 // If greater than zero, mean RTT variation is multiplied by the specified 93 // If greater than zero, mean RTT variation is multiplied by the specified
106 // factor and added to the congestion window limit. 94 // factor and added to the congestion window limit.
107 QUIC_FLAG(double, FLAGS_quic_bbr_rtt_variation_weight, 0.0f) 95 QUIC_FLAG(double, FLAGS_quic_bbr_rtt_variation_weight, 0.0f)
108 96
109 // Congestion window gain for QUIC BBR during PROBE_BW phase. 97 // Congestion window gain for QUIC BBR during PROBE_BW phase.
110 QUIC_FLAG(double, FLAGS_quic_bbr_cwnd_gain, 2.0f) 98 QUIC_FLAG(double, FLAGS_quic_bbr_cwnd_gain, 2.0f)
111 99
112 // If true, do not send or process stop waiting frames in QUIC if the NSTP 100 // If true, do not send or process stop waiting frames in QUIC if the NSTP
113 // connection option is provided. 101 // connection option is provided.
114 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_no_stop_waiting_frames, false) 102 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_no_stop_waiting_frames, false)
115 103
116 // Allows one self address change. 104 // Allows one self address change.
117 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_allow_one_address_change, false) 105 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_allow_one_address_change, false)
118 106
119 // If true, QUIC BBR stores a max filtered number of bytes delivered at a rate 107 // If true, QUIC BBR stores a max filtered number of bytes delivered at a rate
120 // faster than the sending rate. 108 // faster than the sending rate.
121 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes, true) 109 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes, true)
122 110
123 // If true, allow cubic updates on every ack, rather than occasionally limiting
124 // the frequency to once every 30ms.
125 QUIC_FLAG(bool,
126 FLAGS_quic_reloadable_flag_quic_enable_cubic_per_ack_updates,
127 true)
128
129 // Support bandwidth resumption in QUIC BBR. 111 // Support bandwidth resumption in QUIC BBR.
130 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption, false) 112 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_bandwidth_resumption, false)
131 113
132 // Add the equivalent number of bytes as 3 TCP TSO segments to QUIC's BBR CWND. 114 // Add the equivalent number of bytes as 3 TCP TSO segments to QUIC's BBR CWND.
133 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_add_tso_cwnd, false) 115 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_add_tso_cwnd, false)
134 116
135 // If true, enable version 38 which supports new PADDING frame and respects NSTP 117 // If true, enable version 38 which supports new PADDING frame and respects NSTP
136 // connection option. 118 // connection option.
137 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_version_38, true) 119 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_version_38, true)
138 120
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 // from duplicate keys into a single delimted header. 188 // from duplicate keys into a single delimted header.
207 QUIC_FLAG(bool, 189 QUIC_FLAG(bool,
208 FLAGS_quic_reloadable_flag_quic_handle_duplicate_trailers, 190 FLAGS_quic_reloadable_flag_quic_handle_duplicate_trailers,
209 false) 191 false)
210 192
211 // Allows QUIC BBR up to twice the previously measured ack aggregation to be 193 // Allows QUIC BBR up to twice the previously measured ack aggregation to be
212 // added to the CWND as long as bytes_in_flight goes below the target recently. 194 // added to the CWND as long as bytes_in_flight goes below the target recently.
213 QUIC_FLAG(bool, 195 QUIC_FLAG(bool,
214 FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2, 196 FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2,
215 false) 197 false)
OLDNEW
« no previous file with comments | « net/quic/core/congestion_control/tcp_cubic_sender_packets.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698