Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296823008: Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (Closed)

Created:
6 years, 7 months ago by reed2
Modified:
6 years, 7 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/) Reason for revert: required blink change failed to land Original issue's description: > Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) > > This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14830 TBR=scroggo@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+818 lines, -306 lines) Patch
M bench/GradientBench.cpp View 8 chunks +29 lines, -18 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +1 line, -13 lines 0 comments Download
M experimental/SkiaExamples/HelloSkiaExample.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M experimental/webtry/templates/template.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/alphagradients.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/colortype.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradientDirtyLaundry.cpp View 2 chunks +14 lines, -9 lines 0 comments Download
M gm/gradient_matrix.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gradients.cpp View 7 chunks +24 lines, -17 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 20 chunks +65 lines, -37 lines 0 comments Download
M gm/gradients_no_texture.cpp View 4 chunks +31 lines, -24 lines 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 5 chunks +35 lines, -21 lines 0 comments Download
M gm/shadertext2.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M gm/shadertext3.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M gm/tilemodes.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M gm/tilemodes_scaled.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M gyp/SampleApp.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/public_headers.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkReadBuffer.h View 3 chunks +2 lines, -6 lines 0 comments Download
A include/core/SkUnitMapper.h View 1 chunk +37 lines, -0 lines 0 comments Download
M include/effects/SkGradientShader.h View 6 chunks +70 lines, -33 lines 0 comments Download
M samplecode/SampleAll.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M samplecode/SampleGradients.cpp View 4 chunks +21 lines, -14 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleShaderText.cpp View 5 chunks +35 lines, -21 lines 0 comments Download
M samplecode/SampleSlides.cpp View 4 chunks +26 lines, -19 lines 0 comments Download
M samplecode/SampleTiling.cpp View 2 chunks +9 lines, -1 line 0 comments Download
A samplecode/SampleUnitMapper.cpp View 1 chunk +172 lines, -0 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawGradient.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/animator/SkDrawGradient.cpp View 5 chunks +49 lines, -3 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 20 chunks +62 lines, -13 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 3 chunks +3 lines, -0 lines 0 comments Download
A src/utils/SkUnitMappers.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
6 years, 7 months ago (2014-05-22 02:54:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/296823008/1
6 years, 7 months ago (2014-05-22 02:55:32 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 02:56:13 UTC) #3
Message was sent while issue was closed. 
Change committed as 14838

Powered by Google App Engine
This is Rietveld 408576698